Modified github_advisory_sync.rb's new_data variable to add 'patched_versions' and related:'s url… #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reedloden - FYI |
postmodern
requested changes
Apr 10, 2023
lib/github_advisory_sync.rb
Outdated
| file.write new_data.to_yaml | ||
| file.write new_data.merge( | ||
| { "patched_versions" => vulnerabilities }, | ||
| { "related:\nurl:" => advisory["references"] } |
There was a problem hiding this comment.
I think that should be {"related" => {"url" => ...}}.
lib/github_advisory_sync.rb
Outdated
| file.write new_data.to_yaml | ||
| file.write new_data.merge( | ||
| { "patched_versions" => vulnerabilities }, | ||
| { "related:\nurl:" => advisory["references"] } |
There was a problem hiding this comment.
Also these two hashes could probably be combined.
|
@jasnow FYI you seem to keep running |
|
Thanks for the clarification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified github_advisory_sync.rb's new_data variable to add the "patched_versions" and "related:'"/"url:" sections.
The new (unreleased 1-line shell) post processor does the rest to get GHSA files ready for ruby-advisory-db repo. Long term this shell will be turned into Ruby code.