Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added translation to the word New #612

Open
wants to merge 2 commits into
base: rails4
Choose a base branch
from
Open

added translation to the word New #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d60e14c
added translation to the word New
mib32 Oct 15, 2014
f5e4688
russian i18n for views_count
mib32 Oct 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/forem/topics_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def new_since_last_view_text(topic)

if forum_view
if topic_view.nil? && topic.created_at > forum_view.past_viewed_at
content_tag :super, "New"
content_tag :super, t('forem.general.newly_created')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is for a topic, perhaps we could name the key forem.topic.newly_created. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would probably be best, considering there could be a different translation for a feminine/masculine word, depending on the language.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, could you please update this PR for that?

end
end
end
Expand Down
1 change: 1 addition & 0 deletions config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ en:
flagged_for_spam: Your account has been flagged for spam.
cannot_create_topic: You cannot create a new topic at this time.
cannot_create_post: You cannot create a new post at this time.
newly_created: New

access_denied: "You are not allowed to do that."
admin:
Expand Down
8 changes: 8 additions & 0 deletions config/locales/ru.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,17 @@ ru:
few: "%{count} ответов"
many: "%{count} ответов"
other: "%{count} ответа"
views: Просмотры
views_count:
zero: Нет просмотров
one: "%{count} просмотр"
few: "%{count} просмотра"
many: "%{count} просмотров"
other: "%{count} просмотра"
flagged_for_spam: Ваш аккаунт отмечен как спамовый.
cannot_create_topic: Вы не можете сейчас создать тему.
cannot_create_post: Вы не можете сейчас создать новый ответ.
newly_created: Новое

access_denied: Доступ запрещен.
admin:
Expand Down