Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix really_destroy! for ruby 2.3 #292

Merged
merged 2 commits into from
Jan 7, 2016
Merged

Conversation

jhawthorn
Copy link
Collaborator

For some reason in ruby 2.3 this definition was interpreted as private. There was no reason to be defining it where it was, so I've moved it into the paranoia module.

Without this:

  1) Error:
ParanoiaTest#test_real_destroy_dependent_destroy_after_normal_destroy:
NoMethodError: private method `really_destroy!' called for #<ParentModel id: 1, deleted_at: "2016-01-07 00:46:46">
Did you mean?  really_destroyed?
    /home/jhawthorn/src/paranoia/vendor/bundle/gems/activemodel-4.2.5/lib/active_model/attribute_methods.rb:430:in `method_missing'
    test/paranoia_test.rb:493:in `test_real_destroy_dependent_destroy_after_normal_destroy'

John Hawthorn added 2 commits January 6, 2016 16:09
For some reason in ruby 2.3 this definition was interpreted as private.
There was no reason to be defining it where it was, so I've moved it
into the paranoia module.
jhawthorn added a commit that referenced this pull request Jan 7, 2016
Fix really_destroy! for ruby 2.3
@jhawthorn jhawthorn merged commit 49b028e into rubysherpas:rails4 Jan 7, 2016
@jhawthorn jhawthorn deleted the ruby_2_3 branch January 7, 2016 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant