Fix create callback called on destroy #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please rebase your branch with |
|
Would really appreciate getting this fix into the wild :) |
|
@mathieujobin is the requirement just rebasing the branch to core and this will be GTG? thnx |
|
I will have another review after I see all tests passing |
mathieujobin
approved these changes
Jan 19, 2022
|
I have rebased this branch into a new branch. all tests passed. including with the test in #522 I will release later https://github.com/rubysherpas/paranoia/actions/runs/2026193146 |
karunkumar1ly
pushed a commit
to edcast/paranoia
that referenced
this pull request
Feb 6, 2024
* update Rails * add specs for broken case * apply fix Co-authored-by: Djilani Kebaili <djilani.kebaili@epfl.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running into a weird bug in one of our projects while migrating from Rails 5.2 to Rails 6.0. It seems to be due to Rails using
#with_transaction_returning_statuswhen persisting models which takes care of setting the recently-added ivar@_new_record_before_last_commit. Paranoia overrides ActiveRecord's#destroywith#paranoia_destroywhich unfortunately only uses#transaction, so when checking for which callbacks should be run, it was seeing a stale value of@_new_record_before_last_commit, therefore causingafter_create_commithooks to be called again.