-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/non timestamp sentinel value #532
Bugfix/non timestamp sentinel value #532
Conversation
@sas1ni69 You could have done now with your current branch, you could do
the second pick line is equivalent, you could remove it, or it should disappear automatically, if your commit is or I might just merge his PR first.. Thanks for the quick fix. |
def paranoia_sentinel_value | ||
self.class.paranoia_sentinel_value | ||
end | ||
|
||
def deletion_time | ||
send(paranoia_column) | ||
paranoia_column_value.acts_like?(:time) ? paranoia_column_value : deleted_at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting
5247637
to
6512707
Compare
@mathieujobin much better! Thanks for merging his PR. I tried to cherry pick but got bad object. I think it was because I hadn't set up upstream. |
@sas1ni69 I have a git command that makes this easy available in https://github.com/mathieujobin/git-scripts I only have to do |
That looks awesome! Really appreciate you sharing, gonna pick up some of your commands 👯 |
I hope you find many useful ;)
and |
Fixes #531