Skip to content

Commit

Permalink
feat: deprecate connectionModes.mobileDevice and connectionModes.webD…
Browse files Browse the repository at this point in the history 
…evice keys (#1647)
  • Loading branch information
@sandeepdsvs
sandeepdsvs authored Sep 2, 2024
1 parent 4c804c4 commit 7a65529
Show file tree
Hide file tree
Showing 5 changed files with 194 additions and 50 deletions.
132 changes: 108 additions & 24 deletions src/configurations/destinations/am/ui-config.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,24 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.mobileDevice",
"value": true
"configKey": "connectionMode.android",
"value": "device"
},
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionMode.ios",
"value": "device"
},
{
"configKey": "connectionMode.flutter",
"value": "device"
},
{
"configKey": "connectionMode.reactnative",
"value": "device"
},
{
"configKey": "connectionMode.web",
"value": "device"
}
],
"condition": "or"
Expand All @@ -111,12 +123,24 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.mobileDevice",
"value": true
"configKey": "connectionMode.android",
"value": "device"
},
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionMode.ios",
"value": "device"
},
{
"configKey": "connectionMode.flutter",
"value": "device"
},
{
"configKey": "connectionMode.reactnative",
"value": "device"
},
{
"configKey": "connectionMode.web",
"value": "device"
}
],
"condition": "or"
Expand All @@ -131,12 +155,24 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.mobileDevice",
"value": true
"configKey": "connectionMode.android",
"value": "device"
},
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionMode.ios",
"value": "device"
},
{
"configKey": "connectionMode.flutter",
"value": "device"
},
{
"configKey": "connectionMode.reactnative",
"value": "device"
},
{
"configKey": "connectionMode.web",
"value": "device"
}
],
"condition": "or"
Expand Down Expand Up @@ -297,8 +333,20 @@
"value": true
},
{
"configKey": "connectionModes.mobileDevice",
"value": true
"configKey": "connectionMode.android",
"value": "device"
},
{
"configKey": "connectionMode.ios",
"value": "device"
},
{
"configKey": "connectionMode.flutter",
"value": "device"
},
{
"configKey": "connectionMode.reactnative",
"value": "device"
}
],
"condition": "or"
Expand All @@ -323,8 +371,20 @@
"value": true
},
{
"configKey": "connectionModes.mobileDevice",
"value": true
"configKey": "connectionMode.android",
"value": "device"
},
{
"configKey": "connectionMode.ios",
"value": "device"
},
{
"configKey": "connectionMode.flutter",
"value": "device"
},
{
"configKey": "connectionMode.reactnative",
"value": "device"
}
],
"condition": "or"
Expand Down Expand Up @@ -392,8 +452,8 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionMode.web",
"value": "device"
}
]
}
Expand All @@ -407,8 +467,20 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.mobileDevice",
"value": true
"configKey": "connectionMode.android",
"value": "device"
},
{
"configKey": "connectionMode.ios",
"value": "device"
},
{
"configKey": "connectionMode.flutter",
"value": "device"
},
{
"configKey": "connectionMode.reactnative",
"value": "device"
}
]
}
Expand Down Expand Up @@ -455,12 +527,24 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionMode.web",
"value": "device"
},
{
"configKey": "connectionMode.android",
"value": "device"
},
{
"configKey": "connectionMode.ios",
"value": "device"
},
{
"configKey": "connectionMode.flutter",
"value": "device"
},
{
"configKey": "connectionModes.mobileDevice",
"value": true
"configKey": "connectionMode.reactnative",
"value": "device"
}
],
"condition": "or"
Expand Down
32 changes: 22 additions & 10 deletions src/configurations/destinations/fullstory/ui-config.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionMode.web",
"value": "device"
}
]
}
Expand Down Expand Up @@ -125,12 +125,24 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionMode.web",
"value": "device"
},
{
"configKey": "connectionMode.android",
"value": "device"
},
{
"configKey": "connectionMode.ios",
"value": "device"
},
{
"configKey": "connectionModes.mobileDevice",
"value": true
"configKey": "connectionMode.flutter",
"value": "device"
},
{
"configKey": "connectionMode.reactnative",
"value": "device"
}
],
"condition": "or"
Expand Down Expand Up @@ -267,8 +279,8 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionMode.web",
"value": "device"
}
]
}
Expand All @@ -281,8 +293,8 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionMode.web",
"value": "device"
}
]
}
Expand Down
40 changes: 32 additions & 8 deletions src/configurations/destinations/intercom/ui-config.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,24 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionMode.web",
"value": "device"
},
{
"configKey": "connectionModes.mobileDevice",
"value": true
"configKey": "connectionMode.android",
"value": "device"
},
{
"configKey": "connectionMode.ios",
"value": "device"
},
{
"configKey": "connectionMode.flutter",
"value": "device"
},
{
"configKey": "connectionMode.reactnative",
"value": "device"
}
],
"condition": "or"
Expand Down Expand Up @@ -199,12 +211,24 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionModes.web",
"value": "device"
},
{
"configKey": "connectionMode.android",
"value": "device"
},
{
"configKey": "connectionMode.ios",
"value": "device"
},
{
"configKey": "connectionMode.flutter",
"value": "device"
},
{
"configKey": "connectionModes.mobileDevice",
"value": true
"configKey": "connectionMode.reactnative",
"value": "device"
}
],
"condition": "or"
Expand Down
20 changes: 16 additions & 4 deletions src/configurations/destinations/rockerbox/ui-config.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,24 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionModes.web",
"value": "device"
},
{
"configKey": "connectionModes.mobileDevice",
"value": true
"configKey": "connectionMode.android",
"value": "device"
},
{
"configKey": "connectionMode.ios",
"value": "device"
},
{
"configKey": "connectionMode.flutter",
"value": "device"
},
{
"configKey": "connectionMode.reactnative",
"value": "device"
}
],
"condition": "or"
Expand Down
20 changes: 16 additions & 4 deletions src/configurations/destinations/spotifyPixel/ui-config.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,24 @@
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.webDevice",
"value": true
"configKey": "connectionModes.web",
"value": "device"
},
{
"configKey": "connectionModes.mobileDevice",
"value": true
"configKey": "connectionMode.android",
"value": "device"
},
{
"configKey": "connectionMode.ios",
"value": "device"
},
{
"configKey": "connectionMode.flutter",
"value": "device"
},
{
"configKey": "connectionMode.reactnative",
"value": "device"
}
],
"condition": "or"
Expand Down

0 comments on commit 7a65529

Please sign in to comment.