fix: remove support of event stream #1804
Conversation
ItsSudip
requested review from
lvrach,
cisse21,
debanjan97,
am6010,
ssbeefeater,
ruchiramoitra,
shrouti1507,
sandeepdsvs,
krishna2020 and
1abhishekpandey
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request modifies the configuration files for the "LINKEDIN_AUDIENCE" destination. Changes in Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.98.0 #1804 +/- ##
=================================================
Coverage 100.00% 100.00%
=================================================
Files 2 2
Lines 53 53
Branches 7 7
=================================================
Hits 53 53 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
src/configurations/destinations/linkedin_audience/db-config.json(1 hunks)src/configurations/destinations/linkedin_audience/schema.json(0 hunks)
💤 Files with no reviewable changes (1)
- src/configurations/destinations/linkedin_audience/schema.json
🔇 Additional comments (1)
src/configurations/destinations/linkedin_audience/db-config.json (1)
Line range hint 1-29: Verify impact on existing integrations
Since this change removes cloud support, we should ensure this won't break existing integrations.
#!/bin/bash
# Description: Check for potential breaking changes
# Search for references to LinkedIn Audience cloud mode in other configuration files
echo "Checking references to LinkedIn Audience cloud mode..."
rg -l "LINKEDIN_AUDIENCE.*cloud" src/configurations/
# Check if there are any migration guides or documentation that need updating
echo "Checking for documentation that might need updates..."
fd -t f . docs -e md -e mdx | xargs rg -l "LINKEDIN_AUDIENCE.*cloud"| "supportedSourceTypes": ["warehouse"], | ||
| "supportedMessageTypes": { | ||
| "cloud": ["record"] | ||
| }, | ||
| "supportedConnectionModes": { | ||
| "cloud": ["cloud"], | ||
| "warehouse": ["cloud"] | ||
| }, | ||
| "destConfig": { | ||
| "defaultConfig": ["rudderAccountId"], | ||
| "cloud": ["connectionMode", "oneTrustCookieCategories", "ketchConsentPurposes"], | ||
| "warehouse": ["connectionMode", "oneTrustCookieCategories", "ketchConsentPurposes"] | ||
| }, | ||
| "secretKeys": [] |
There was a problem hiding this comment.
💡 Codebase verification
Cloud mode references should be removed for consistency
The verification confirms that cloud-related configurations should be removed from db-config.json for consistency:
supportedSourceTypesalready excludes "cloud", indicating the intended direction- No cloud-related configurations exist in
schema.json ui-config.jsononly shows warehouse-related configurations- The remaining cloud references in
db-config.jsonappear to be orphaned:- "supportedMessageTypes": { - "cloud": ["record"] - }, - "supportedConnectionModes": { - "warehouse": ["cloud"] - },
🔗 Analysis chain
Inconsistent removal of cloud-related configurations
While "cloud" has been removed from supportedSourceTypes, it's still referenced in:
supportedMessageTypes.cloudsupportedConnectionModes.warehouse: ["cloud"]
This partial removal could lead to confusion and potential runtime issues.
To ensure consistency, please verify if these configurations should also be updated:
"supportedSourceTypes": ["warehouse"],
"supportedMessageTypes": {
- "cloud": ["record"]
},
"supportedConnectionModes": {
"warehouse": ["cloud"]
},Let's verify other files for similar patterns:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for other cloud-related configurations in LinkedIn Audience integration
# Search for cloud-related configurations in LinkedIn Audience files
echo "Searching for cloud configurations in LinkedIn Audience files..."
rg -l "cloud" src/configurations/destinations/linkedin_audience/
# Check schema.json for related configurations
echo "Checking schema.json for related configurations..."
if [ -f "src/configurations/destinations/linkedin_audience/schema.json" ]; then
jq 'paths | select(.[] | tostring | contains("cloud"))' src/configurations/destinations/linkedin_audience/schema.json
fi
Length of output: 548
Script:
#!/bin/bash
# Let's try a more focused search approach
# 1. Check for cloud-related configurations in the specific file
echo "Content of db-config.json:"
cat src/configurations/destinations/linkedin_audience/db-config.json
# 2. Search for any cloud-related patterns in the linkedin_audience directory
echo -e "\nSearching for 'cloud' in linkedin_audience directory:"
rg "cloud" src/configurations/destinations/linkedin_audience/
# 3. Look for any other config files in the linkedin_audience directory
echo -e "\nListing all files in linkedin_audience directory:"
fd . src/configurations/destinations/linkedin_audience/
Length of output: 1571
Script:
#!/bin/bash
# Let's check the schema.json and ui-config.json for any cloud-related configurations
# Check schema.json content
echo "Content of schema.json:"
cat src/configurations/destinations/linkedin_audience/schema.json
# Check ui-config.json content
echo -e "\nContent of ui-config.json:"
cat src/configurations/destinations/linkedin_audience/ui-config.json
# Search for any connection mode related patterns
echo -e "\nSearching for connectionMode patterns:"
rg -A 3 -B 3 "connectionMode" src/configurations/destinations/linkedin_audience/
Length of output: 7225
What are the changes introduced in this PR?
We are removing support of event stream.
What is the related Linear task?
Resolves INT-XXX
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new checks got introduced or modified in test suites. Please explain the changes.
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
I have executed schemaGenerator tests and updated schema if needed
Are sensitive fields marked as secret in definition config?
My test cases and placeholders use only masked/sample values for sensitive fields
Is the PR limited to 10 file changes & one task?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit
New Features
Bug Fixes