Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: data residency support #149

Merged
merged 20 commits into from
Feb 2, 2023
Merged

feat: data residency support #149

merged 20 commits into from
Feb 2, 2023

Conversation

1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented Oct 26, 2022 •
edited by SumanthPuram
Loading

Description of the change

Implemented data residency in Android.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@desusai7 desusai7 self-requested a review October 31, 2022 05:24
desusai7
desusai7 previously approved these changes Oct 31, 2022
View reviewed changes
@pallabmaiti
Copy link
Contributor

Let's clean up RudderDataResidencyManager class. Can you have a call with @itsdebs?

@itsdebs itsdebs self-requested a review November 1, 2022 09:53
itsdebs
itsdebs previously approved these changes Nov 1, 2022
View reviewed changes
@1abhishekpandey @desusai7
fix: Address the change in the dataPlaneUrl format (#154)
59fe149 
* (Fix) Fixed issues in UnitTest Cases for fetchAllEventsFromDB (#153)

* Fixed issues in UnitTest Cases for fetchAllEventsFromDB

* Minor cleanup

Co-authored-by: Desu Sai Venkat <desusaivenkat@Desus-MacBook-Pro.local>

* fix: Address the change in the dataPlane format

* test: Improved test cases

* fix: Optimise the gson config handler for DataResidency

* fix: remove unnecessary checking for region

Co-authored-by: Desu Sai Venkat <48179357+desusai7@users.noreply.github.com>
Co-authored-by: Desu Sai Venkat <desusaivenkat@Desus-MacBook-Pro.local>
@1abhishekpandey 1abhishekpandey changed the title feat: Data Residency Support feat: data residency support Nov 24, 2022
@1abhishekpandey @itsdebs
test: improve flush api throttling test case (#184)
a4cbce7 
* test: make events to test throttling off `flush` api calls

* fix: move the assertion block outside of thread

* fix: resolve the test getting stuck at while loop

* fix: remove safety mechanism

* chore: improve logic

* refactor: optimised code

* fix: added throttling test

* fix: remove test case

* chore: remove unused imports

Co-authored-by: Debanjan Chatterjee <debanjanchatterjee99@gmail.com>
desusai7
desusai7 previously approved these changes Nov 30, 2022
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

desusai7
desusai7 previously approved these changes Feb 2, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@1abhishekpandey 1abhishekpandey merged commit acb06bb into develop Feb 2, 2023
@1abhishekpandey 1abhishekpandey deleted the feat/dataResidency branch February 2, 2023 12:13
@1abhishekpandey 1abhishekpandey restored the feat/dataResidency branch February 2, 2023 12:13
@1abhishekpandey 1abhishekpandey deleted the feat/dataResidency branch May 18, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsdebs itsdebs itsdebs approved these changes

@pallabmaiti pallabmaiti pallabmaiti approved these changes

@desusai7 desusai7 desusai7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1abhishekpandey @pallabmaiti @itsdebs @desusai7