Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) Fixed issues in UnitTest Cases for fetchAllEventsFromDB #153

Merged
merged 2 commits into from
Nov 1, 2022
Merged

(Fix) Fixed issues in UnitTest Cases for fetchAllEventsFromDB #153

merged 2 commits into from
Nov 1, 2022

Conversation

desusai7
Copy link
Contributor

@desusai7 desusai7 commented Oct 31, 2022 •
edited
Loading

Description of the change

(Fix) Fixed issues in UnitTest Cases for fetchAllEventsFromDB

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@desusai7 desusai7 self-assigned this Oct 31, 2022
@1abhishekpandey 1abhishekpandey merged commit 24d97fc into develop Nov 1, 2022
@1abhishekpandey 1abhishekpandey deleted the fix/unitTestEventRepository branch November 1, 2022 06:15
1abhishekpandey added a commit that referenced this pull request Nov 15, 2022
@1abhishekpandey @desusai7
fix: Address the change in the dataPlaneUrl format (#154)
59fe149 
* (Fix) Fixed issues in UnitTest Cases for fetchAllEventsFromDB (#153)

* Fixed issues in UnitTest Cases for fetchAllEventsFromDB

* Minor cleanup

Co-authored-by: Desu Sai Venkat <desusaivenkat@Desus-MacBook-Pro.local>

* fix: Address the change in the dataPlane format

* test: Improved test cases

* fix: Optimise the gson config handler for DataResidency

* fix: remove unnecessary checking for region

Co-authored-by: Desu Sai Venkat <48179357+desusai7@users.noreply.github.com>
Co-authored-by: Desu Sai Venkat <desusaivenkat@Desus-MacBook-Pro.local>
1abhishekpandey added a commit that referenced this pull request Feb 2, 2023
@1abhishekpandey @desusai7 @itsdebs
feat: data residency support (#149)
acb06bb 
* feat: Implemented Data Residency

* docs: Implemented comments in DataResidency URL.

* chore: Bumped the version to `1.8.0`

* refactor: Changed enum class to `DataResidencyServer`

* refactor: Moved methods into Utils class

* refactor: Optimised getDataResidencyUrl API

* refactor: Change method name to `appendSlashToUrl`

* refactor: Change logic to handle dataPlaneUrl

* chore: Replace manual version with Constants.RUDDER_LIBRARY_VERSION

* refactor: Rename to RudderDataResidencyManager

* refactor: Rename to RudderDataResidencyServer

* chore: Fixed the region check to small case only.

* test: Make the config object from spy to mock

* fix: Optimised flushWorkerManager based (#150)

* fix: Address the change in the dataPlaneUrl format (#154)

* (Fix) Fixed issues in UnitTest Cases for fetchAllEventsFromDB (#153)

* Fixed issues in UnitTest Cases for fetchAllEventsFromDB

* Minor cleanup

Co-authored-by: Desu Sai Venkat <desusaivenkat@Desus-MacBook-Pro.local>

* fix: Address the change in the dataPlane format

* test: Improved test cases

* fix: Optimise the gson config handler for DataResidency

* fix: remove unnecessary checking for region

Co-authored-by: Desu Sai Venkat <48179357+desusai7@users.noreply.github.com>
Co-authored-by: Desu Sai Venkat <desusaivenkat@Desus-MacBook-Pro.local>

* test: improve flush api throttling test case (#184)

* test: make events to test throttling off `flush` api calls

* fix: move the assertion block outside of thread

* fix: resolve the test getting stuck at while loop

* fix: remove safety mechanism

* chore: improve logic

* refactor: optimised code

* fix: added throttling test

* fix: remove test case

* chore: remove unused imports

Co-authored-by: Debanjan Chatterjee <debanjanchatterjee99@gmail.com>

* fix: changed try to try with resources (#185)

* chore: addressing comment

---------

Co-authored-by: Desu Sai Venkat <48179357+desusai7@users.noreply.github.com>
Co-authored-by: Desu Sai Venkat <desusaivenkat@Desus-MacBook-Pro.local>
Co-authored-by: Debanjan Chatterjee <debanjanchatterjee99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsdebs itsdebs itsdebs approved these changes

@1abhishekpandey 1abhishekpandey 1abhishekpandey approved these changes

@pallabmaiti pallabmaiti Awaiting requested review from pallabmaiti

Assignees

@desusai7 desusai7

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desusai7 @itsdebs @1abhishekpandey