test: improve flush api throttling test case #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1abhishekpandey
requested review from
pallabmaiti and
itsdebs
as code owners
1abhishekpandey
changed the title
desusai7
pushed a commit
that referenced
this pull request
Jan 25, 2023
* test: make events to test throttling off `flush` api calls * fix: move the assertion block outside of thread * fix: resolve the test getting stuck at while loop * fix: remove safety mechanism * chore: improve logic * refactor: optimised code * fix: added throttling test * fix: remove test case * chore: remove unused imports Co-authored-by: Debanjan Chatterjee <debanjanchatterjee99@gmail.com>
1abhishekpandey
added a commit
that referenced
this pull request
Feb 2, 2023
* feat: Implemented Data Residency * docs: Implemented comments in DataResidency URL. * chore: Bumped the version to `1.8.0` * refactor: Changed enum class to `DataResidencyServer` * refactor: Moved methods into Utils class * refactor: Optimised getDataResidencyUrl API * refactor: Change method name to `appendSlashToUrl` * refactor: Change logic to handle dataPlaneUrl * chore: Replace manual version with Constants.RUDDER_LIBRARY_VERSION * refactor: Rename to RudderDataResidencyManager * refactor: Rename to RudderDataResidencyServer * chore: Fixed the region check to small case only. * test: Make the config object from spy to mock * fix: Optimised flushWorkerManager based (#150) * fix: Address the change in the dataPlaneUrl format (#154) * (Fix) Fixed issues in UnitTest Cases for fetchAllEventsFromDB (#153) * Fixed issues in UnitTest Cases for fetchAllEventsFromDB * Minor cleanup Co-authored-by: Desu Sai Venkat <desusaivenkat@Desus-MacBook-Pro.local> * fix: Address the change in the dataPlane format * test: Improved test cases * fix: Optimise the gson config handler for DataResidency * fix: remove unnecessary checking for region Co-authored-by: Desu Sai Venkat <48179357+desusai7@users.noreply.github.com> Co-authored-by: Desu Sai Venkat <desusaivenkat@Desus-MacBook-Pro.local> * test: improve flush api throttling test case (#184) * test: make events to test throttling off `flush` api calls * fix: move the assertion block outside of thread * fix: resolve the test getting stuck at while loop * fix: remove safety mechanism * chore: improve logic * refactor: optimised code * fix: added throttling test * fix: remove test case * chore: remove unused imports Co-authored-by: Debanjan Chatterjee <debanjanchatterjee99@gmail.com> * fix: changed try to try with resources (#185) * chore: addressing comment --------- Co-authored-by: Desu Sai Venkat <48179357+desusai7@users.noreply.github.com> Co-authored-by: Desu Sai Venkat <desusaivenkat@Desus-MacBook-Pro.local> Co-authored-by: Debanjan Chatterjee <debanjanchatterjee99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Type of change
Checklist:
This change is