Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sessionId not getting cleared issue #300

Merged
merged 2 commits into from
Sep 19, 2023
Merged

fix: sessionId not getting cleared issue #300

merged 2 commits into from
Sep 19, 2023

Conversation

1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented Sep 6, 2023 •
edited
Loading

Description

  • Fix the logic to clear the sessionId, when it is changed from on to off.
  • Make session logic dependent upon the withNewLifecycleEvents API, along with old lifecycle and session tracking API's.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@1abhishekpandey
fxi: sessionId not getting cleared when automatic lifecycle changes
114b1ce 
Also, take into consideration the new lifecycle api
@1abhishekpandey 1abhishekpandey self-assigned this Sep 6, 2023
desusai7
desusai7 previously approved these changes Sep 8, 2023
View reviewed changes
itsdebs
itsdebs previously approved these changes Sep 8, 2023
View reviewed changes
@1abhishekpandey 1abhishekpandey added Work in progress work in progress and removed Ready for review labels Sep 8, 2023
@1abhishekpandey
fix: add new lifecycle api support in applySessionTracking method
e3ce77a 
Currently it is not taking the new lifecycle api
@1abhishekpandey 1abhishekpandey dismissed stale reviews from itsdebs and desusai7 via e3ce77a September 8, 2023 12:25
@1abhishekpandey 1abhishekpandey added Ready for review and removed Work in progress work in progress labels Sep 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@1abhishekpandey 1abhishekpandey mentioned this pull request Sep 8, 2023
Merged
10 tasks
@1abhishekpandey 1abhishekpandey merged commit 12e09ca into develop Sep 19, 2023
@1abhishekpandey 1abhishekpandey deleted the feature/sdk-549-sessionid-is-not-cleared-when-automatic-lifecycle-changes branch September 19, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsdebs itsdebs itsdebs approved these changes

@desusai7 desusai7 desusai7 approved these changes

@pallabmaiti pallabmaiti Awaiting requested review from pallabmaiti

Assignees

@1abhishekpandey 1abhishekpandey

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1abhishekpandey @itsdebs @desusai7