Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add getsessionid api support #301

Merged
merged 3 commits into from
Sep 19, 2023
Merged

feat: add getsessionid api support #301

merged 3 commits into from
Sep 19, 2023

Conversation

1abhishekpandey
Copy link
Contributor

Description

  • Implement getSessionId() API support

This PR also contains changes from #300

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@1abhishekpandey 1abhishekpandey changed the title Feature/sdk 302 provide getsessionid support feat: add getsessionid api support Sep 8, 2023
@1abhishekpandey 1abhishekpandey mentioned this pull request Sep 8, 2023
Closed
10 tasks
@1abhishekpandey 1abhishekpandey self-assigned this Sep 11, 2023
@1abhishekpandey 1abhishekpandey merged commit d63f1d2 into develop Sep 19, 2023
@1abhishekpandey 1abhishekpandey deleted the feature/sdk-302-provide-getsessionid-support branch September 19, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsdebs itsdebs itsdebs approved these changes

@desusai7 desusai7 desusai7 approved these changes

@pallabmaiti pallabmaiti Awaiting requested review from pallabmaiti

Assignees

@1abhishekpandey 1abhishekpandey

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1abhishekpandey @itsdebs @desusai7