Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added filter for rudderstack crashes #325

Merged
merged 3 commits into from
Oct 3, 2023
Merged

fix: added filter for rudderstack crashes #325

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1de6b47
fix: added filter for rudderstack crashes
itsdebs Sep 27, 2023
fe58b80
chore: update rudderreporter version
itsdebs Oct 3, 2023
8295ea1
Merge branch 'develop' into fix/sdk-185-filter-errors-only-related-to…
itsdebs Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions core/src/main/java/com/rudderstack/android/sdk/core/ReportManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@
import com.rudderstack.android.ruddermetricsreporterandroid.LibraryMetadata;
import com.rudderstack.android.ruddermetricsreporterandroid.Metrics;
import com.rudderstack.android.ruddermetricsreporterandroid.RudderReporter;
import com.rudderstack.android.ruddermetricsreporterandroid.error.CrashFilter;
import com.rudderstack.android.ruddermetricsreporterandroid.error.ErrorClient;
import com.rudderstack.android.ruddermetricsreporterandroid.metrics.LongCounter;
import com.rudderstack.gsonrudderadapter.GsonAdapter;

import java.util.Collections;
import java.util.Map;

public class ReportManager {
Expand Down Expand Up @@ -173,12 +175,9 @@ private static void checkAndUpdateErrorsCollection(boolean isErrorsEnabled) {
private static void initiateRudderReporter(Context context, @Nullable String writeKey,
boolean isMetricsEnabled, boolean isErrorsEnabled) {
RudderLogger.logDebug("EventRepository: Creating RudderReporter isMetricsEnabled: " + isMetricsEnabled + " isErrorsEnabled: " + isErrorsEnabled);
String writeKeyOrBlank = writeKey == null ? "" : writeKey;
if (rudderReporter == null) {
rudderReporter = new DefaultRudderReporter(context, METRICS_URL_PROD,
new Configuration(new LibraryMetadata(
BuildConfig.LIBRARY_PACKAGE_NAME, BuildConfig.VERSION_NAME, BuildConfig.VERSION_CODE, writeKeyOrBlank
)), new GsonAdapter(), isMetricsEnabled, isErrorsEnabled);
getStatsConfig(writeKey), new GsonAdapter(), isMetricsEnabled, isErrorsEnabled);
rudderReporter.getSyncer().startScheduledSyncs(METRICS_UPLOAD_INTERVAL,
true, METRICS_FLUSH_COUNT);
//we default to null if metrics or errors are not enabled
Expand All @@ -187,6 +186,15 @@ private static void initiateRudderReporter(Context context, @Nullable String wri
}
}

private static Configuration getStatsConfig(@Nullable String writeKey) {
String writeKeyOrBlank = writeKey == null ? "" : writeKey;
Configuration config = new Configuration(new LibraryMetadata(
BuildConfig.LIBRARY_PACKAGE_NAME, BuildConfig.VERSION_NAME, BuildConfig.VERSION_CODE, writeKeyOrBlank
));
config.setCrashFilter(CrashFilter.generateWithKeyWords(Collections.singletonList("rudderstack")));
return config;
}

static void incrementMessageCounter(int value, Map<String, String> attributes) {
incrementCounter(messageCounter, value, attributes);
}
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/com/rudderstack/android/sdk/core/RudderNetworkManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ private HttpURLConnection updateHttpConnection(String requestURL, RequestMethod
return updateHttpConnection(httpConnection, requestMethod, requestPayload, isDMTRequest,
null, null);
} catch (Exception ex) {
ReportManager.reportError(ex);
// ReportManager.reportError(ex);
RudderLogger.logError("RudderNetworkManager: sendNetworkRequest: Exception occurred while creating HttpURLConnection" + ex.getLocalizedMessage());
return null;
}
Expand Down Expand Up @@ -238,7 +238,7 @@ private HttpURLConnection updateHttpConnectionForPostRequest(HttpURLConnection h
osw.flush();
return httpConnection;
} catch (Exception ex) {
ReportManager.reportError(ex);
// ReportManager.reportError(ex);
RudderLogger.logError("RudderNetworkManager: updateHttpConnection: Error while updating the http connection" + ex.getLocalizedMessage());
return null;
}
Expand Down
3 changes: 2 additions & 1 deletion sample-kotlin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ android {
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
buildConfigField("String", "DATA_PLANE_URL", properties.getProperty('dataplaneUrl', 'https://api.rudderstack.com'))
buildConfigField("String", "CONTROL_PLANE_URL", properties.getProperty('controlplaneUrl', "\"https://api.rudderstack.com\""))
buildConfigField("String", "WRITE_KEY", properties.getProperty('writeKey', ''))
buildConfigField("String", "WRITE_KEY", properties.getProperty('writeKey', "\"\""))
}
buildTypes {
debug {
Expand Down Expand Up @@ -63,6 +63,7 @@ dependencies {

// Rudder Android Core SDK
implementation project(':core')
// implementation 'com.rudderstack.android.sdk:core:1.19.1'
implementation 'com.google.code.gson:gson:2.8.6'
implementation "androidx.work:work-runtime:2.7.1"

Expand Down