chore: fix validations in workflows (#1982)

* chore: log gh api response * chore: fix response assertion * chore: fix conditions in workflows for actor validations
rudderlabs · Dec 27, 2024 · c5b8cb8 · c5b8cb8
1 parent fcb2dca
commit c5b8cb8
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 14 deletions.
diff --git a/.github/workflows/deploy-dev.yml b/.github/workflows/deploy-dev.yml
@@ -9,7 +9,7 @@ on:
 
 jobs:
   validate-actor:
-    # Run only for workflow_dispatch events with a merged pull request
+    # Run only for workflow_dispatch events
     if: github.event_name == 'workflow_dispatch'
     uses: ./.github/workflows/validate-actor.yml
     secrets:

diff --git a/.github/workflows/deploy-npm.yml b/.github/workflows/deploy-npm.yml
@@ -26,10 +26,8 @@ env:
 
 jobs:
   validate-actor:
-    # Run validation for workflow_dispatch with tags
-    if: >
-      github.event_name == 'workflow_dispatch' &&
-      startsWith(github.ref, 'refs/tags/v')
+    # Run validation for workflow_dispatch
+    if: github.event_name == 'workflow_dispatch'
     uses: ./.github/workflows/validate-actor.yml
     secrets:
       PAT: ${{ secrets.PAT }}
@@ -42,7 +40,14 @@ jobs:
     # Deploy if validate-actor was successful or skipped
     # or if the workflow was invoked by another workflow
     if: >
-      (needs.validate-actor.result == 'success' || needs.validate-actor.result == 'skipped') || inputs.is_called == 'true'
+      (needs.validate-actor.result == 'success' || needs.validate-actor.result == 'skipped') &&
+      (
+        inputs.is_called == 'true' ||
+        (
+          github.event_name == 'workflow_dispatch' &&
+          startsWith(github.ref, 'refs/tags/v')
+        )
+      )
 
     steps:
       - name: Checkout

diff --git a/.github/workflows/deploy-staging.yml b/.github/workflows/deploy-staging.yml
@@ -11,13 +11,7 @@ on:
 
 jobs:
   validate-actor:
-    if: >
-      github.event_name == 'workflow_dispatch' &&
-      (
-        startsWith(github.ref, 'refs/tags/v') ||
-        startsWith(github.head_ref, 'hotfix-release/') ||
-        startsWith(github.head_ref, 'release/')
-      )
+    if: github.event_name == 'workflow_dispatch'
     uses: ./.github/workflows/validate-actor.yml
     secrets:
       PAT: ${{ secrets.PAT }}

diff --git a/.github/workflows/validate-actor.yml b/.github/workflows/validate-actor.yml
@@ -28,7 +28,7 @@ jobs:
           fi
 
           # Extract the state of the membership
-          if echo "$response" | grep -q '"state": "active"'; then
+          if echo "$response" | grep -q '"state":"active"'; then
             echo "'$actor' is a member of '@${ORG_NAME}/${TEAM_NAME}' team"
           else
             echo "Error: '$actor' is NOT a member of '@${ORG_NAME}/${TEAM_NAME}' team. Access denied."