feat: move error reporting functionality to the core module #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: delete error reporting plugins and deprecate them * refactor: pluginsmanager test suite
* feat: delete error reporting plugins and deprecate them * chore: add bugsnag dev dependency * feat: implement error reporting in core * chore: use bugsnag types * fix: resolve circular dependency in httpclient * refactor: remove unused compare function * fix: stackframe types
* feat: improve user callback execution * fix: error message for callback parameter validation
* feat: improve user callback execution * feat: make error handler and logger mandatory in all components
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 31 files out of 113 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2011 +/- ##
===========================================
- Coverage 61.30% 61.29% -0.02%
===========================================
Files 484 478 -6
Lines 16626 16394 -232
Branches 3340 3257 -83
===========================================
- Hits 10192 10048 -144
+ Misses 5213 5113 -100
- Partials 1221 1233 +12 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
|
arpl
approved these changes
Jan 22, 2025
ChryssaAliferi
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I've moved the error reporting functionality to the core SDK and deleted the ErrorReporting and Bugsnag plugins.
The SDK can report errors as soon as it loads and don't have to wait for plugins to finish loading.
Now, there are no parts in the SDK that throw errors left to be handled by the global exception handlers.
Additional updates:
Linear task (optional)
https://linear.app/rudderstack/issue/SDK-2826/move-error-reporting-functionality-to-the-core-sdk
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security