Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Auto capture anonymous id #497

Merged
merged 23 commits into from
Apr 25, 2022
Merged

Feature: Auto capture anonymous id #497

merged 23 commits into from
Apr 25, 2022

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Apr 13, 2022 •
edited by SumanthPuram
Loading

Description of the change

For the customers migrating from Segment, SDK will auto capture Segment’s anonymousID and set it as RS’s anonymousID.

  • Added an option in the load call, autoAssignAnonId. If you set it to segment, it will auto capture the anonymousID if present in cookie or local storage.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@MoumitaM MoumitaM requested a review from pallabmaiti April 13, 2022 11:59
@MoumitaM MoumitaM requested a review from saikumarrs as a code owner April 13, 2022 11:59
@MoumitaM MoumitaM self-assigned this Apr 13, 2022
saikumarrs
saikumarrs requested changes Apr 13, 2022
View reviewed changes
analytics.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
utils/storage/storage.js Outdated Show resolved Hide resolved
utils/storage/storage.js Outdated Show resolved Hide resolved
utils/storage/storage.js Outdated Show resolved Hide resolved
utils/storage/storage.js Show resolved Hide resolved
utils/storage/storage.js Outdated Show resolved Hide resolved
utils/storage/storage.js Outdated Show resolved Hide resolved
MoumitaM and others added 5 commits April 13, 2022 19:16
@MoumitaM @saikumarrs
Update utils/storage/storage.js
397ca64 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM @saikumarrs
Update utils/storage/storage.js
b65d371 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM @saikumarrs
Update utils/storage/storage.js
4ec6dab 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM
code refactoring
1a08cdc
@MoumitaM
added checking for cookie support existance
b780d40
saikumarrs
saikumarrs reviewed Apr 14, 2022
View reviewed changes
analytics.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM requested a review from saikumarrs April 14, 2022 11:39
@saikumarrs saikumarrs changed the title Feature : Auto capture segment's anonymous id Feature: Auto capture anonymous id Apr 14, 2022
MoumitaM and others added 3 commits April 17, 2022 11:01
@MoumitaM
updated type declaration
6cc8c82
@MoumitaM @saikumarrs
Update utils/storage/storage.js
9aeceb1 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM
code refactoring
e2b3ca1
@MoumitaM MoumitaM requested a review from saikumarrs April 17, 2022 08:40
saikumarrs
saikumarrs reviewed Apr 17, 2022
View reviewed changes
utils/storage/cookie.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM requested a review from saikumarrs April 19, 2022 07:20
@MoumitaM MoumitaM requested a review from saikumarrs April 19, 2022 15:50
saikumarrs
saikumarrs previously approved these changes Apr 19, 2022
View reviewed changes
pallabmaiti
pallabmaiti previously approved these changes Apr 21, 2022
View reviewed changes
@MoumitaM MoumitaM dismissed stale reviews from pallabmaiti and saikumarrs via f026395 April 22, 2022 12:04
@saikumarrs
Copy link
Member

PR description doesn't match with the implementation.

saikumarrs
saikumarrs reviewed Apr 22, 2022
View reviewed changes
utils/storage/cookie.js Outdated Show resolved Hide resolved
saikumarrs
saikumarrs reviewed Apr 22, 2022
View reviewed changes
utils/storage/cookie.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM requested a review from saikumarrs April 22, 2022 14:22
@MoumitaM @saikumarrs
Update utils/storage/storage.js
9581912 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM MoumitaM requested a review from saikumarrs April 22, 2022 17:23
saikumarrs
saikumarrs reviewed Apr 23, 2022
View reviewed changes
utils/storage/cookie.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM requested a review from saikumarrs April 24, 2022 17:22
@MoumitaM MoumitaM merged commit e4fa754 into v1-staging Apr 25, 2022
@MoumitaM MoumitaM deleted the collect-anon-id/segment branch April 25, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@pallabmaiti pallabmaiti Awaiting requested review from pallabmaiti

Assignees

@MoumitaM MoumitaM

Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoumitaM @saikumarrs @pallabmaiti