Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(Vero-web-device-mode): new Integrations Vero web device mode #549

Merged
merged 16 commits into from
Jul 7, 2022

Conversation

sauravlal-rudderstack
Copy link
Contributor

@sauravlal-rudderstack sauravlal-rudderstack commented Jun 28, 2022

Description of the change

new Integrations Vero web device mode

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

Copy link
Member

@ItsSudip ItsSudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add tag call after every event call if tag information is there.

integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/index.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
utsabc
utsabc previously approved these changes Jul 4, 2022
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Show resolved Hide resolved
Copy link
Member

@saikumarrs saikumarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some critical typos.

integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
integrations/Vero/browser.js Outdated Show resolved Hide resolved
@ItsSudip ItsSudip requested a review from saikumarrs July 6, 2022 11:43
@ItsSudip ItsSudip requested a review from saikumarrs July 6, 2022 12:20
@utsabc utsabc merged commit 1880c1b into v1-staging Jul 7, 2022
@utsabc utsabc deleted the feature/vero branch July 7, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants