-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(Vero-web-device-mode): new Integrations Vero web device mode #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauravlal-rudderstack
requested review from
utsabc and
saikumarrs
as code owners
June 28, 2022 07:33
ItsSudip
reviewed
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add tag call after every event call if tag information is there.
saikumarrs
reviewed
Jun 30, 2022
utsabc
reviewed
Jul 4, 2022
saikumarrs
reviewed
Jul 4, 2022
utsabc
reviewed
Jul 4, 2022
utsabc
reviewed
Jul 4, 2022
ItsSudip
reviewed
Jul 4, 2022
utsabc
reviewed
Jul 4, 2022
utsabc
previously approved these changes
Jul 4, 2022
ItsSudip
reviewed
Jul 5, 2022
saikumarrs
reviewed
Jul 5, 2022
saikumarrs
requested changes
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some critical typos.
saikumarrs
reviewed
Jul 5, 2022
ItsSudip
reviewed
Jul 5, 2022
saikumarrs
reviewed
Jul 5, 2022
saikumarrs
reviewed
Jul 6, 2022
saikumarrs
reviewed
Jul 6, 2022
saikumarrs
reviewed
Jul 6, 2022
saikumarrs
approved these changes
Jul 7, 2022
utsabc
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review
This change is