Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/ga4 debug mode support #565

Merged
merged 2 commits into from
Jul 21, 2022
Merged

feature/ga4 debug mode support #565

merged 2 commits into from
Jul 21, 2022

Conversation

yashasvibajpai
Copy link
Member

@yashasvibajpai yashasvibajpai commented Jul 13, 2022 •
edited by SumanthPuram
Loading

Description of the change

Add debug_mode support for GA4. The parameter is managed via config

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@yashasvibajpai yashasvibajpai self-assigned this Jul 13, 2022
@yashasvibajpai yashasvibajpai added the enhancement New feature or request label Jul 13, 2022
saikumarrs
saikumarrs previously approved these changes Jul 15, 2022
View reviewed changes
@yashasvibajpai yashasvibajpai merged commit e2ad2dc into v1-staging Jul 21, 2022
@yashasvibajpai yashasvibajpai deleted the feature/ga4-debug-mode-support branch July 21, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@utsabc utsabc Awaiting requested review from utsabc

Assignees

@yashasvibajpai yashasvibajpai

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashasvibajpai @saikumarrs