Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flattening nested objects for Intercom "track" events #593

Merged

Conversation

ariel-talent-fabric
Copy link
Contributor

@ariel-talent-fabric ariel-talent-fabric commented Aug 2, 2022

Description of the change

Intercom "trackEvent" does not support nested object payloads. The purpose of this PR is to recursively flatten nested object events so they can be sent to the Intercom API.

Type of change

  • [v] New feature (non-breaking change that adds functionality)

Related issues

Checklists

Development

  • [ v] Lint rules pass locally

Code review

  • [v] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • [v] Changes have been reviewed by at least one other engineer

This change is Reviewable

Intercom "trackEvent" does not support nested object payloads. The purpose of this PR is to recursively flatten nested object events so they can be sent to the Intercom API.
@ariel-talent-fabric
Copy link
Contributor Author

@ItsSudip any update on this?

@ItsSudip
Copy link
Member

ItsSudip commented Aug 23, 2022

@ItsSudip any update on this?

We are working on it. It will be available with our next release. So you can expect it by the coming week. A quick question. We have already implemented one flatten logic in our code base but instead of using _ we are using .. Do you need to use _ only?

@saikumarrs saikumarrs requested a review from ItsSudip August 24, 2022 03:21
@ariel-talent-fabric
Copy link
Contributor Author

In general I dont have a preference, I just don't know if the intercom API will work with . instead of _ .
Feel free to change it in the way you see fit.

@ItsSudip
Copy link
Member

ItsSudip commented Sep 1, 2022

In general I dont have a preference, I just don't know if the intercom API will work with . instead of _ . Feel free to change it in the way you see fit.

I checked in Intercom. Their API works with .. I have made the changes. Our next release is scheduled for the 7th of September. It will be available after that. Thanks for understanding and keeping patience.

@saikumarrs saikumarrs changed the base branch from production to production-staging September 6, 2022 05:57
@saikumarrs saikumarrs merged commit 12e53b2 into rudderlabs:production-staging Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants