-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SameSite None to fix embedded version #610
Add SameSite None to fix embedded version #610
Conversation
@saikumarrs, yes, great advice! Thank you, I will do so! |
Thanks. The changes look good to me. I left a comment to address a minor issue. As a next step, please sign the CLA using this form. |
bbef228
to
28ed782
Compare
@saikumarrs done |
@GSokol Thanks. We'll absorb this PR and release a new SDK version next week. |
ea7e68c
to
14c2c4c
Compare
Move the setting to config.
14c2c4c
to
8c4ae88
Compare
@GSokol Thanks for your patience. We are currently swamped and won't be able to release a new version of the SDK this week. However, we've added this to our immediate sprint roadmap and will include it in the next week's release. |
…dded_version_work_proper
…dded_version_work_proper
The embedded version fof the site failed to use cookies, so it generates
new anonymous id. Fixing it.
Description of the change
Type of change
Related issues
Checklists
Development
Code review
This change is