Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: VWO loadintegration option #614

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Fix: VWO loadintegration option #614

merged 3 commits into from
Aug 22, 2022

Conversation

yashasvibajpai
Copy link
Member

@yashasvibajpai yashasvibajpai commented Aug 18, 2022 •
edited by SumanthPuram
Loading

Description of the change

Relocate loadIntegration check in VWO to a non-blocker check.
Add JS SDK loadIntegration support for VWO

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@yashasvibajpai yashasvibajpai self-assigned this Aug 18, 2022
@yashasvibajpai yashasvibajpai changed the title Fix: VWO loadintegration optio Fix: VWO loadintegration option Aug 18, 2022
@yashasvibajpai yashasvibajpai marked this pull request as ready for review August 18, 2022 22:55
@yashasvibajpai yashasvibajpai requested a review from utsabc as a code owner August 18, 2022 22:55
@yashasvibajpai yashasvibajpai merged commit 2adee37 into v1-staging Aug 22, 2022
@yashasvibajpai yashasvibajpai deleted the fix/vwo-load-integration branch August 22, 2022 05:42
saikumarrs added a commit that referenced this pull request Aug 23, 2022
@saikumarrs
Revert "Fix: VWO loadintegration option (#614)"
62bb828 
This reverts commit 2adee37.
@yashasvibajpai yashasvibajpai mentioned this pull request Aug 23, 2022
Merged
yashasvibajpai added a commit that referenced this pull request Aug 23, 2022
@yashasvibajpai @saikumarrs
Revert "Fix: VWO loadintegration option" changes (#618)
acf6f97 
Revert "Fix: VWO loadintegration option (#614)"

This reverts commit 2adee37.

Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoumitaM MoumitaM MoumitaM approved these changes

@utsabc utsabc utsabc approved these changes

@saikumarrs saikumarrs Awaiting requested review from saikumarrs

Assignees

@yashasvibajpai yashasvibajpai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yashasvibajpai @utsabc @MoumitaM @saikumarrs