Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(new integration): SnapEngage web Device mode integration onboarding-v1.1 #620

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

rohithkaza
Copy link
Contributor

@rohithkaza rohithkaza commented Aug 23, 2022

Description of the change

Onboarding SnapEngage-v1.1

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

Copy link
Contributor

@MoumitaM MoumitaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure config backend changes are released.

@github-actions
Copy link

github-actions bot commented Aug 23, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 37.01 KB (+0.15% 🔺) 741 ms (+0.15% 🔺) 795 ms (-22.38% 🔽) 1.6 s
All Integrations - CDN 734.21 KB (+6.11% 🔺) 14.7 s (+6.11% 🔺) 3.9 s (+19.94% 🔺) 18.6 s
Core - NPM 37.23 KB (+0.17% 🔺) 745 ms (+0.17% 🔺) 504 ms (-32.68% 🔽) 1.3 s

@rohithkaza rohithkaza merged commit 0f58741 into production-staging Aug 23, 2022
@rohithkaza rohithkaza deleted the feature/snapengage-production branch August 23, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants