Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Intercom) : remove unwanted code #639

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Sep 6, 2022

Description of the change

We are removing the flattenEventObject function as we are using an existing util function.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@saikumarrs saikumarrs changed the title feat(Intercom) :: Removing unwanted code. refactor(Intercom) : remove unwanted code Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 37.16 KB (0%) 744 ms (0%) 596 ms (-1.72% 🔽) 1.4 s
All Integrations - CDN 777.36 KB (-0.02% 🔽) 15.6 s (-0.02% 🔽) 3.3 s (-7.23% 🔽) 18.9 s
Core - NPM 37.37 KB (0%) 748 ms (0%) 433 ms (+10.49% 🔺) 1.2 s

@ItsSudip ItsSudip merged commit 7b15cc8 into production-staging Sep 6, 2022
@ItsSudip ItsSudip deleted the feat/intercom branch September 6, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants