Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(service-worker): new service worker compatible SDK with samples #668

Merged
merged 8 commits into from
Oct 17, 2022

Conversation

bardisg
Copy link
Contributor

@bardisg bardisg commented Sep 27, 2022

Description of the change

Addition of a service worker compatible version based on the NodeJS SDK that can be used in a service worker.
Samples for using both the JS SDK and the service worker SDK in a Chrome extension with manifest v3

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

[> Fix #1 ](https://www.notion.so/rudderstacks/Use-JS-SDK-in-service-worker-93f577b3618a4ffbb4c591c1e207965f)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@bardisg bardisg changed the title Poc/chrome extension feat:(service-worker): new service worker compatible SDK with samples Sep 27, 2022
@github-actions
Copy link

github-actions bot commented Sep 27, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 38.47 KB (0%) 770 ms (0%) 583 ms (-2.61% 🔽) 1.4 s
All Integrations - CDN 1.05 MB (0%) 21.5 s (0%) 6.2 s (+18.38% 🔺) 27.7 s
Core - NPM 38.69 KB (0%) 774 ms (0%) 359 ms (-36.71% 🔽) 1.2 s

@bardisg bardisg added the Ready for review Changes are ready to be reviewed label Sep 27, 2022
@bardisg bardisg changed the base branch from production to production-staging September 30, 2022 12:11
package.json Show resolved Hide resolved
service-worker/index.js Show resolved Hide resolved
tests/chrome-extension/background-script/service-worker.js Outdated Show resolved Hide resolved
@bardisg bardisg requested a review from MoumitaM October 17, 2022 09:07
@bardisg bardisg merged commit aad7095 into production-staging Oct 17, 2022
@bardisg bardisg deleted the poc/chrome-extension branch October 17, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants