Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved page/track calls braze #669

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

aashishmalik
Copy link
Contributor

@aashishmalik aashishmalik commented Sep 27, 2022

Description of the change

We are missing validation of userId in Braze web device mode. We have to add a button in the dashboard, it will help us to decide if we want to track the anonymous users or not. Apart from that, we have to update the page call as well. If the user doesn’t provide any page name we will add the name as page view .

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • [-] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@aashishmalik aashishmalik force-pushed the feat/trackAnanoymousUserBraze branch from a21d8bb to 0a2140c Compare September 27, 2022 12:43
@aashishmalik aashishmalik merged commit b348fb9 into v1-staging Oct 11, 2022
@aashishmalik aashishmalik deleted the feat/trackAnanoymousUserBraze branch October 11, 2022 06:20
@aashishmalik aashishmalik removed the request for review from saikumarrs October 26, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants