Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new integration): Engage - onboard integration #672

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Sep 30, 2022

Description of the change

Onboarding Engaging Destination

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Sep 30, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 38.35 KB (+0.12% 🔺) 767 ms (+0.12% 🔺) 138 ms (-31.18% 🔽) 905 ms
All Integrations - CDN 1002.93 KB (+4.4% 🔺) 20.1 s (+4.4% 🔺) 1.6 s (+5.45% 🔺) 21.6 s
Core - NPM 38.57 KB (+0.1% 🔺) 772 ms (+0.1% 🔺) 198 ms (+6.74% 🔺) 969 ms

Copy link
Contributor

@MoumitaM MoumitaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for logger module to work add the below code in browser.js.

  1. Add analytics in the constructor
    constructor(config, analytics) {
  2. Add the below code in the constructor.
    if (analytics.logLevel) { logger.setLogLevel(analytics.logLevel); }

@anantjain45823 anantjain45823 merged commit 4530627 into production-staging Oct 6, 2022
@anantjain45823 anantjain45823 deleted the feat/Engage branch October 6, 2022 05:49
@anantjain45823 anantjain45823 restored the feat/Engage branch October 6, 2022 05:49
@anantjain45823 anantjain45823 deleted the feat/Engage branch October 6, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Ready for review Changes are ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants