Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: common names map update #681

Merged
merged 3 commits into from
Oct 17, 2022
Merged

fix: common names map update #681

merged 3 commits into from
Oct 17, 2022

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Oct 14, 2022 •
edited by SumanthPuram
Loading

Description of the change

Common Names Map Update

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@anantjain45823 anantjain45823 changed the base branch from production to v1-staging October 14, 2022 13:14
@anantjain45823 anantjain45823 self-assigned this Oct 14, 2022
MoumitaM
MoumitaM requested changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@MoumitaM MoumitaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the mapping has repetitive values. Remove those values.

integrations/Adroll/constants.js Outdated Show resolved Hide resolved
integrations/Appcues/constants.js Outdated Show resolved Hide resolved
integrations/Braze/constants.js Outdated Show resolved Hide resolved
@anantjain45823 anantjain45823 added the Ready for review Changes are ready to be reviewed label Oct 17, 2022
@anantjain45823 anantjain45823 merged commit ebddf62 into v1-staging Oct 17, 2022
@anantjain45823 anantjain45823 deleted the fix/CNameUpdate branch October 17, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrouti1507 shrouti1507 shrouti1507 approved these changes

@MoumitaM MoumitaM MoumitaM approved these changes

@utsabc utsabc Awaiting requested review from utsabc

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

Assignees

@anantjain45823 anantjain45823

Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anantjain45823 @MoumitaM @shrouti1507 @anantrudder