Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/yandex_metirca: onbaording yandex_metrica #687

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

ujjwal-ab
Copy link
Contributor

@ujjwal-ab ujjwal-ab commented Oct 18, 2022

Description of the change

onbaording yandex_metrica

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@ujjwal-ab ujjwal-ab added the Ready for review Changes are ready to be reviewed label Oct 18, 2022
@ujjwal-ab ujjwal-ab requested a review from utsabc as a code owner October 18, 2022 06:51
@ujjwal-ab ujjwal-ab self-assigned this Oct 18, 2022
@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 39.07 KB (+0.23% 🔺) 782 ms (+0.23% 🔺) 200 ms (+11.57% 🔺) 981 ms
All Integrations - CDN 1.1 MB (+4.1% 🔺) 22.7 s (+4.1% 🔺) 1.7 s (+5.68% 🔺) 24.3 s
Core - NPM 39.28 KB (+0.21% 🔺) 786 ms (+0.21% 🔺) 181 ms (+7.72% 🔺) 967 ms

@ujjwal-ab ujjwal-ab merged commit 49c0eb8 into production-staging Oct 18, 2022
@ujjwal-ab ujjwal-ab deleted the feature/yandex_metrica-v1.1 branch October 18, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants