Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service-worker): fix npm package exports and types #696

Merged
merged 3 commits into from
Oct 21, 2022
Merged

fix(service-worker): fix npm package exports and types #696

merged 3 commits into from
Oct 21, 2022

Conversation

bardisg
Copy link
Contributor

@bardisg bardisg commented Oct 20, 2022 •
edited
Loading

Description of the change

Fix the exports and type definitions in package json for the npm package

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1
Notion task

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@bardisg bardisg added the Ready for review Changes are ready to be reviewed label Oct 20, 2022
@github-actions
Copy link

github-actions bot commented Oct 20, 2022 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 39.07 KB (0%) 782 ms (0%) 146 ms (-18.05% 🔽) 928 ms
All Integrations - CDN 1.1 MB (0%) 22.7 s (0%) 2.1 s (+3.91% 🔺) 24.7 s
Core - NPM 39.28 KB (0%) 786 ms (0%) 261 ms (+23.52% 🔺) 1.1 s

MoumitaM
MoumitaM previously approved these changes Oct 20, 2022
View reviewed changes
@bardisg bardisg requested a review from MoumitaM October 20, 2022 14:19
@bardisg bardisg merged commit 1883367 into production Oct 21, 2022
@bardisg bardisg deleted the hotfix/package-exports-and-types-issue-695 branch October 21, 2022 07:38
bardisg added a commit that referenced this pull request Oct 21, 2022
@bardisg
fix(service-worker): fix npm package exports and types (#696) (#700)
1592e60 
* fix(service-worker): fix npm package exports and types

* chore: add more code  owner users

* chore: update service worker docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@MoumitaM MoumitaM Awaiting requested review from MoumitaM

Assignees
No one assigned
Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG : V2.17.x causes build error when done inside a Docker container
3 participants
@bardisg @MoumitaM @saikumarrs