Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refiner device mode code removed #705

Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix: refiner device mode code removed #705

merged 1 commit into from
Oct 25, 2022

Conversation

mihir-4116
Copy link
Contributor

@mihir-4116 mihir-4116 commented Oct 25, 2022 •
edited
Loading

Description of the change

  • this is a pr to remove refiner code from v1-staging branch. merging this branch to v1-staging will remove all refiner device mode code.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • [ ✅] "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@mihir-4116 mihir-4116 added the Ready for review Changes are ready to be reviewed label Oct 25, 2022
@mihir-4116 mihir-4116 self-assigned this Oct 25, 2022
@mihir-4116 mihir-4116 merged commit 1d54380 into v1-staging Oct 25, 2022
@mihir-4116 mihir-4116 deleted the remove/refiner branch October 25, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@shrouti1507 shrouti1507 shrouti1507 approved these changes

@MoumitaM MoumitaM Awaiting requested review from MoumitaM

@utsabc utsabc Awaiting requested review from utsabc

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

Assignees

@mihir-4116 mihir-4116

Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihir-4116 @shrouti1507 @saikumarrs