Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove IntegrationState and simplify IntegrationPlugin #113

Draft
wants to merge 74 commits into
base: develop
Choose a base branch
from
Draft

refactor: remove IntegrationState and simplify IntegrationPlugin #113

wants to merge 74 commits into from
+419 −280

Conversation

vgupta98
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Vishal Gupta added 30 commits December 26, 2024 17:11
feat: add DeviceModeDestinationPlugin and StartupQueuePlugin
09da8cb
refactor: change StartupQueuePlugin to use HashSet
5f0c076
feat: add DestinationPlugin
fea280f
refactor: remove StartupQueue and move logic to DeviceModeDestination…
924e0ab 
…Plugin
refactor: DestinationPlugin and DeviceModeDestinationPlugin
3a8c72c
feat: add EventProcessor and EventProcessorFacade
e7e92bd
refactor: change sourceConfig logic in DeviceModeDestinationPlugin
f0a508d
feat: add a sample amplitude destination plugin
4de710c
refactor: make DeviceModeDestinationPlugin nullable
3f03278
refactor: move reset and flush logic to DeviceModeDestinationPlugin
62f1981
refactor: extract out default event processor list
97d0d4b
refactor: make public api methods as protected in DestinationPlugin
8386588
refactor: use PluginChain and plugin architecture instead of EventPro…
34337cc 
…cessorFacade
refactor: add EventFilteringPlugin and change add plugin logic for De…
05980fb 
…stinationPlugin
refactor: remove EventFilteringPlugin and IntegrationOptionsPlugin
f48470f
refactor: make deviceModeDestinationPlugin initialisation synchronised
8682327
refactor: change initialize login in DestinationPlugin
d6ac9a6
refactor: change DestinationPlugin Apis logic to avoid unitialized ex…
86f9cee 
…ception
refactor: refactor DeviceModeDestinationPlugin
84b7aa1
refactor: make amplitudeSdk in SampleAmplitudePlugin nullable
b6e5823
refactor: use EventPlugin in DestinationPlugin
5d05a80
refactor: refactor create to return DestinationResult and add getUnde…
7a3a60f 
…rlyingInstance api
refactor: change logic for DestinationPlugin and DeviceModeDestinatio…
1f60a7c 
…nPlugin
refactor: make handleEvents method in EventPlugin
ca2fbd2
refactor: add internal modifiers in DeviceModeDestinationPlugin
6b616e4
refactor: make pluginChain instance of Analytics class as private
c72024e
refactor: rename DestinationPlugin to IntegrationPlugin
3ba12b0
refactor: rename DeviceModeDestinationPlugin to IntegrationsManagemen…
2adb599 
…tPlugin
refactor: add nullability in identify and alias apis in EventPlugin
590864b
refactor: rename methods in IntegrationsManagementPlugin
3b00f38
Vishal Gupta added 23 commits January 16, 2025 10:49
test: update IntegrationPluginTest to cover more scenarios
9081129
test: update IntegrationsManagementPluginTest
245db58
feat: add destination updation logic for an integration
063dfcc
test: update IntegrationPluginTest to include update logic tests
b8f3c50
refactor: change the logic for updation of a destination
26040da
test: update IntegrationsManagementPluginTest to include destination …
4a96d91 
…updation
test: update IntegrationPluginTest with scenarios for dynamic update
3d5758b
Merge branch 'develop' into feat/sdk-2861-implement-dynamic-destinati…
7db3037 
…on-update
refactor: change the sourceConfig collection code in IntegrationsMana…
46aae52 
…gementPlugin to make it more clean
refactor: use safelyExecute method for create and update in Integrati…
79d6962 
…onPlugin
refactor: add Synchronized annotation for initAndNotifyCallbacks as i…
5a2bfec 
…t can be called from multiple threads
refactor: change getUnderlyingInstance name to getDestinationInstance
c4ca4a2
refactor: change signature for create method in IntegrationPlugin
eb52acd
refactor: rename DestinationState to IntegrationState
129bf52
refactor: update IntegrationPlugin
c422853
Merge branch 'develop' into feat/sdk-2861-implement-dynamic-destinati…
57d530a 
…on-update
refactor: change IntegrationsManagementPlugin's ogic to handle first …
59bc681 
…emission of SourceConfig
refactor: change update logic in SampleIntegrationPlugin
b388554
test: change update logic for MockDestinationIntegrationPlugin
c9bf016
test: update IntegrationPluginTest
20bc01d
test: update MockDestinationSdk to not return spy object for detinati…
3e10189 
…on SDK to mimic real behaviour
test: add test for updation of destinationConfig
b16f8c5
refactor: remove IntegrationState and simplify IntegrationPlugin
b5ec459
@vgupta98 vgupta98 force-pushed the refactor/sdk-2904-dynamic-update-without-integration-state-improved branch 3 times, most recently from 2af27fd to f873b32 Compare January 30, 2025 13:28
@vgupta98 vgupta98 force-pushed the refactor/sdk-2904-dynamic-update-without-integration-state-improved branch from f873b32 to 3659be0 Compare January 30, 2025 13:31
Base automatically changed from feat/sdk-2861-implement-dynamic-destination-update to develop January 31, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1abhishekpandey 1abhishekpandey 1abhishekpandey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vgupta98 @1abhishekpandey