chore: limit max retry interval for transformer

rudderlabs · Aug 16, 2024 · 96e0d51 · 96e0d51
1 parent e2fe003
commit 96e0d51
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/processor/transformer/transformer.go b/processor/transformer/transformer.go
@@ -172,6 +172,7 @@ type handle struct {
  maxRetry config.ValueLoader[int]
  failOnUserTransformTimeout config.ValueLoader[bool]
  failOnError config.ValueLoader[bool]
+ maxRetryBackoffInterval config.ValueLoader[time.Duration]
 
  destTransformationURL string
  userTransformationURL string
@@ -203,6 +204,8 @@ func NewTransformer(conf *config.Config, log logger.Logger, stat stats.Stats, op
  trans.config.failOnUserTransformTimeout = conf.GetReloadableBoolVar(false, "Processor.Transformer.failOnUserTransformTimeout")
  trans.config.failOnError = conf.GetReloadableBoolVar(false, "Processor.Transformer.failOnError")
 
+ trans.config.maxRetryBackoffInterval = conf.GetReloadableDurationVar(30, time.Second, "Processor.Transformer.maxRetryBackoffInterval")
+
  trans.guardConcurrency = make(chan struct{}, trans.config.maxConcurrency)
 
  if trans.client == nil {
@@ -439,6 +442,9 @@ func (trans *handle) doPost(ctx context.Context, rawJSON []byte, url, stage stri
  resp *http.Response
  respData []byte
  )
+ retryStrategy := backoff.NewExponentialBackOff()
+ // MaxInterval caps the RetryInterval
+ retryStrategy.MaxInterval = trans.config.maxRetryBackoffInterval.Load()
 
  err := backoff.RetryNotify(
  func() error {
@@ -473,7 +479,7 @@ func (trans *handle) doPost(ctx context.Context, rawJSON []byte, url, stage stri
  respData, reqErr = io.ReadAll(resp.Body)
  return reqErr
  },
- backoff.WithMaxRetries(backoff.NewExponentialBackOff(), uint64(trans.config.maxRetry.Load())),
+ backoff.WithMaxRetries(retryStrategy, uint64(trans.config.maxRetry.Load())),
  func(err error, t time.Duration) {
  retryCount++
  trans.logger.Warnn(