Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: by default enable max concurrent gw request limit. #2648

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

saurav-malani
Copy link
Contributor

Description

Enable max concurrent gateway request limit with default value of 50000.

Discussion ref: https://rudderlabs.slack.com/archives/C01JF5MGUAG/p1667401042399559

Notion Ticket

https://www.notion.so/rudderstacks/enable-max-concurrent-gw-request-limit-ce0781d221984678a0f843823d50d303

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 43.90% // Head: 43.86% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (667d67a) compared to base (3659e12).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2648      +/-   ##
==========================================
- Coverage   43.90%   43.86%   -0.05%     
==========================================
  Files         187      187              
  Lines       40038    40038              
==========================================
- Hits        17579    17561      -18     
- Misses      21363    21376      +13     
- Partials     1096     1101       +5     
Impacted Files Coverage Δ
gateway/configuration.go 96.36% <100.00%> (ø)
enterprise/reporting/setup.go 38.09% <0.00%> (-14.29%) ⬇️
utils/httputil/server.go 80.76% <0.00%> (-11.54%) ⬇️
config/backend-config/namespace_config.go 70.83% <0.00%> (-3.13%) ⬇️
enterprise/reporting/reporting.go 8.33% <0.00%> (-1.44%) ⬇️
services/rsources/handler.go 69.72% <0.00%> (-1.39%) ⬇️
processor/processor.go 72.23% <0.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chandumlg chandumlg merged commit d673640 into master Nov 11, 2022
@chandumlg chandumlg deleted the chore.setDefaultMaxConcurrentReqLimit branch November 11, 2022 06:48
atzoum added a commit that referenced this pull request Dec 1, 2022
feat(warehouse): added support for bigquery custom partition for workspaceIDs (#2679)
chore: by default enable max concurrent gw request limit. (#2648)
doc: create SECURITY.md (#2656)
chore: use bugsnag in router and processor goroutines (#2686)
test: using arm64 compatible images if necessary (#2670)
chore: regulation worker avoid panic in case of timeout (#2657)
feat(warehouse): degraded workspace id (#2627)
Release-As: 1.4.0
atzoum added a commit that referenced this pull request Dec 1, 2022
feat(warehouse): added support for bigquery custom partition for workspaceIDs (#2679)
chore: by default enable max concurrent gw request limit. (#2648)
doc: create SECURITY.md (#2656)
chore: use bugsnag in router and processor goroutines (#2686)
test: using arm64 compatible images if necessary (#2670)
chore: regulation worker avoid panic in case of timeout (#2657)
feat(warehouse): degraded workspace id (#2627)
Release-As: 1.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants