Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: create SECURITY.md #2656

Merged
merged 6 commits into from
Nov 10, 2022
Merged

doc: create SECURITY.md #2656

merged 6 commits into from
Nov 10, 2022

Conversation

ameypv-rudder
Copy link
Contributor

@ameypv-rudder ameypv-rudder commented Nov 7, 2022

Description

Added a SECURITY.md file with the relevant contact email for reporting any security-related issues.

Notion Ticket

https://www.notion.so/rudderstacks/Add-security-md-to-all-the-major-public-repos-d6696c93147f4d8299302fa59c4ad465

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@ameypv-rudder ameypv-rudder added the documentation Improvements or additions to documentation label Nov 7, 2022
@ameypv-rudder ameypv-rudder self-assigned this Nov 7, 2022
SECURITY.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 43.66% // Head: 43.07% // Decreases project coverage by -0.58% ⚠️

Coverage data is based on head (ff44580) compared to base (2f956b7).
Patch has no changes to coverable lines.

❗ Current head ff44580 differs from pull request most recent head a134ef5. Consider uploading reports for the commit a134ef5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2656      +/-   ##
==========================================
- Coverage   43.66%   43.07%   -0.59%     
==========================================
  Files         191      335     +144     
  Lines       40483    52705   +12222     
==========================================
+ Hits        17677    22703    +5026     
- Misses      21700    28610    +6910     
- Partials     1106     1392     +286     
Impacted Files Coverage Δ
regulation-worker/internal/client/client.go 66.42% <0.00%> (-0.97%) ⬇️
warehouse/warehouse.go 8.42% <0.00%> (-0.26%) ⬇️
warehouse/api.go 70.41% <0.00%> (ø)
warehouse/retry.go 87.58% <0.00%> (ø)
warehouse/identities.go 1.04% <0.00%> (ø)
warehouse/table_upload.go 93.92% <0.00%> (ø)
warehouse/archiver.go
warehouse/datalake/schema-repository/glue.go 0.00% <0.00%> (ø)
...ices/streammanager/eventbridge/mock_eventbridge.go 100.00% <0.00%> (ø)
app/apphandlers/setup.go 78.94% <0.00%> (ø)
... and 230 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
@chrikar
Copy link
Contributor

chrikar commented Nov 7, 2022

Let's also add a notion task link for this @ameypv-rudder

Co-authored-by: Christos Kargas <2836342+chrikar@users.noreply.github.com>
@ameypv-rudder
Copy link
Contributor Author

@chrikar done! If you can approve, we can merge this and proceed with the other repos in the same format.

@atzoum
Copy link
Contributor

atzoum commented Nov 9, 2022

we could also add a supported versions section and mention that we will fix security bugs for the latest major.minor version published in docker hub.

eg. something similar to that:
https://github.com/quarkusio/quarkus/blob/main/SECURITY.md

@ameypv-rudder
Copy link
Contributor Author

we could also add a supported versions section and mention that we will fix security bugs for the latest major.minor version published in docker hub.

eg. something similar to that: https://github.com/quarkusio/quarkus/blob/main/SECURITY.md

Makes sense, @atzoum - where/who can I get this information re: supported versions from?

@atzoum
Copy link
Contributor

atzoum commented Nov 10, 2022

we could also add a supported versions section and mention that we will fix security bugs for the latest major.minor version published in docker hub.
eg. something similar to that: https://github.com/quarkusio/quarkus/blob/main/SECURITY.md

Makes sense, @atzoum - where/who can I get this information re: supported versions from?

Our releases are here. We don't need to specify specific release, since we don't want to update the document all the time, simply use a similar generic table, e.g.

Version Supported
latest 1.x
older 1.x
< 1.0

SECURITY.md Show resolved Hide resolved
Co-authored-by: Aris Tzoumas <atzoumas@rudderstack.com>
@ameypv-rudder
Copy link
Contributor Author

@atzoum thanks Aris for your suggestions - I've incorporated those in the PR.

@atzoum atzoum changed the title Create SECURITY.md doc: create SECURITY.md Nov 10, 2022
@atzoum atzoum merged commit 17be4fa into master Nov 10, 2022
@atzoum atzoum deleted the security-contact-update branch November 10, 2022 13:42
This was referenced Nov 11, 2022
atzoum added a commit that referenced this pull request Dec 1, 2022
feat(warehouse): added support for bigquery custom partition for workspaceIDs (#2679)
chore: by default enable max concurrent gw request limit. (#2648)
doc: create SECURITY.md (#2656)
chore: use bugsnag in router and processor goroutines (#2686)
test: using arm64 compatible images if necessary (#2670)
chore: regulation worker avoid panic in case of timeout (#2657)
feat(warehouse): degraded workspace id (#2627)
Release-As: 1.4.0
atzoum added a commit that referenced this pull request Dec 1, 2022
feat(warehouse): added support for bigquery custom partition for workspaceIDs (#2679)
chore: by default enable max concurrent gw request limit. (#2648)
doc: create SECURITY.md (#2656)
chore: use bugsnag in router and processor goroutines (#2686)
test: using arm64 compatible images if necessary (#2670)
chore: regulation worker avoid panic in case of timeout (#2657)
feat(warehouse): degraded workspace id (#2627)
Release-As: 1.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants