chore: regulation worker avoid panic in case of timeout #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
reviewed
Nov 7, 2022
atzoum
force-pushed
the
chore.regulationWorkerFailSafe
branch
from
6b6a4dd
to
a7a9796
Compare
Codecov ReportBase: 45.60% // Head: 45.46% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2657 +/- ##
==========================================
- Coverage 45.60% 45.46% -0.14%
==========================================
Files 287 289 +2
Lines 47790 47937 +147
==========================================
+ Hits 21793 21794 +1
- Misses 24619 24760 +141
- Partials 1378 1383 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
saurav-malani
force-pushed
the
chore.regulationWorkerFailSafe
branch
from
a7a9796
to
1beba87
Compare
saurav-malani
force-pushed
the
chore.regulationWorkerFailSafe
branch
from
01f360f
to
8204ff7
Compare
atzoum
reviewed
Nov 8, 2022
atzoum
reviewed
Nov 8, 2022
atzoum
reviewed
Nov 8, 2022
atzoum
reviewed
Nov 8, 2022
atzoum
reviewed
Nov 8, 2022
|
@saurav-malani @chandumlg do we want this to be included in |
|
alert for timeouts: https://github.com/rudderlabs/rudderstack-operator/pull/906 |
|
@atzoum if everything looks good, then it would be great to include it in release, otherwise we will have the use the image of the PR in regulation-worker deployment. |
fracasula
approved these changes
Nov 8, 2022
atzoum
approved these changes
Nov 8, 2022
This was referenced Dec 1, 2022
Closed
Merged
atzoum
added a commit
that referenced
this pull request
Dec 1, 2022
feat(warehouse): added support for bigquery custom partition for workspaceIDs (#2679) chore: by default enable max concurrent gw request limit. (#2648) doc: create SECURITY.md (#2656) chore: use bugsnag in router and processor goroutines (#2686) test: using arm64 compatible images if necessary (#2670) chore: regulation worker avoid panic in case of timeout (#2657) feat(warehouse): degraded workspace id (#2627) Release-As: 1.4.0
atzoum
added a commit
that referenced
this pull request
Dec 1, 2022
feat(warehouse): added support for bigquery custom partition for workspaceIDs (#2679) chore: by default enable max concurrent gw request limit. (#2648) doc: create SECURITY.md (#2656) chore: use bugsnag in router and processor goroutines (#2686) test: using arm64 compatible images if necessary (#2670) chore: regulation worker avoid panic in case of timeout (#2657) feat(warehouse): degraded workspace id (#2627) Release-As: 1.4.0
This was referenced Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notion Ticket
https://www.notion.so/rudderstacks/regulation-manager-worker-fail-safe-with-metrics-alert-a6c1eee073924651a15e9caad45750d7