Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: using arm64 compatible images if necessary #2670

Merged
merged 3 commits into from
Nov 9, 2022
Merged

test: using arm64 compatible images if necessary #2670

merged 3 commits into from
Nov 9, 2022

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Nov 8, 2022

Description

  • Enabling all tests in arm64 machines (m1 macbooks)
  • Fixing flaky multitenant test

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 45.46% // Head: 45.45% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4ae63dc) compared to base (a0da8f7).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2670      +/-   ##
==========================================
- Coverage   45.46%   45.45%   -0.02%     
==========================================
  Files         289      289              
  Lines       47928    47940      +12     
==========================================
- Hits        21792    21789       -3     
- Misses      24758    24768      +10     
- Partials     1378     1383       +5     
Impacted Files Coverage Δ
testhelper/destination/kafka.go 76.11% <40.00%> (-2.12%) ⬇️
testhelper/etcd/etcd.go 65.90% <40.00%> (-4.10%) ⬇️
config/backend-config/noop.go 0.00% <0.00%> (-42.11%) ⬇️
config/backend-config/namespace_config.go 70.83% <0.00%> (-3.13%) ⬇️
services/db/recovery.go 50.60% <0.00%> (-1.21%) ⬇️
processor/processor.go 85.99% <0.00%> (ø)
router/router.go 74.04% <0.00%> (+0.18%) ⬆️
router/manager/manager.go 100.00% <0.00%> (+3.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum requested a review from pChondros November 8, 2022 10:42
@atzoum atzoum merged commit e2402b6 into master Nov 9, 2022
@atzoum atzoum deleted the test.arm64 branch November 9, 2022 07:31
atzoum added a commit that referenced this pull request Dec 1, 2022
feat(warehouse): added support for bigquery custom partition for workspaceIDs (#2679)
chore: by default enable max concurrent gw request limit. (#2648)
doc: create SECURITY.md (#2656)
chore: use bugsnag in router and processor goroutines (#2686)
test: using arm64 compatible images if necessary (#2670)
chore: regulation worker avoid panic in case of timeout (#2657)
feat(warehouse): degraded workspace id (#2627)
Release-As: 1.4.0
atzoum added a commit that referenced this pull request Dec 1, 2022
feat(warehouse): added support for bigquery custom partition for workspaceIDs (#2679)
chore: by default enable max concurrent gw request limit. (#2648)
doc: create SECURITY.md (#2656)
chore: use bugsnag in router and processor goroutines (#2686)
test: using arm64 compatible images if necessary (#2670)
chore: regulation worker avoid panic in case of timeout (#2657)
feat(warehouse): degraded workspace id (#2627)
Release-As: 1.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants