-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: advertise gzip support to transformer through X-Feature-Gzip-Support header #3990
Conversation
@@ -455,6 +455,7 @@ func (trans *handle) doPost(ctx context.Context, rawJSON []byte, url, stage stri | |||
} | |||
|
|||
req.Header.Set("Content-Type", "application/json; charset=utf-8") | |||
req.Header.Set("X-Feature-Gzip-Support", "?1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why are we using ?1
as a value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandumlg kept this value, from transformer we accept '?1' and 'true'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any special meaning or something we come up with it. just curious.
@@ -455,6 +455,7 @@ func (trans *handle) doPost(ctx context.Context, rawJSON []byte, url, stage stri | |||
} | |||
|
|||
req.Header.Set("Content-Type", "application/json; charset=utf-8") | |||
req.Header.Set("X-Feature-Gzip-Support", "?1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any special meaning or something we come up with it. just curious.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.15.x #3990 +/- ##
==================================================
- Coverage 71.74% 70.36% -1.38%
==================================================
Files 368 357 -11
Lines 55126 53667 -1459
==================================================
- Hits 39548 37765 -1783
- Misses 13320 13634 +314
- Partials 2258 2268 +10
☔ View full report in Codecov by Sentry. |
* chore: advertise gzip support to transformer through X-Feature-Gzip-Support header (#3990) * chore: release 1.15.2 (#3992) * fix: update error parsing of eloqua (#3996) * fix(eloqua): change null values to empty strings inspite of "null" * address comments * add logic to consider some warning statusCode as success * fix lint issues * fix: corrupted rsources stats captured by processor for dropped jobs (#3999) * chore: release 1.15.3 (#3998) * fix: invalid memory address or nil pointer dereference in googlecloudfunction * fix: merge error blocks in gcf * chore: add test case for body close * chore: add test case for body close --------- Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com> Co-authored-by: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: Aris Tzoumas <atzoumas@rudderstack.com>
Description
Resolves INT-873
Adding the gzip support header in transformer.go for backward compatibility between server <> transformer
Linear Ticket
#3904
Security