fix: merge error blocks in gcf #4004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(eloqua): change null values to empty strings inspite of "null" * address comments * add logic to consider some warning statusCode as success * fix lint issues
sanpj2292
approved these changes
Oct 24, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4004 +/- ##
=======================================
Coverage 71.54% 71.54%
=======================================
Files 368 368
Lines 54153 54152 -1
=======================================
+ Hits 38744 38745 +1
+ Misses 13102 13100 -2
Partials 2307 2307
☔ View full report in Codecov by Sentry. |
achettyiitr
approved these changes
Oct 25, 2023
This was referenced Oct 30, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge Error blocks for better readability
Linear Ticket
< Replace with Linear Link >
Security