fix: update error parsing of eloqua #3996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koladilip
reviewed
Oct 19, 2023
koladilip
approved these changes
Oct 19, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.15.x #3996 +/- ##
=================================================
Coverage ? 70.38%
=================================================
Files ? 357
Lines ? 53684
Branches ? 0
=================================================
Hits ? 37785
Misses ? 13627
Partials ? 2272 ☔ View full report in Codecov by Sentry. |
Merged
1 task
koladilip
added a commit
that referenced
this pull request
Oct 25, 2023
* chore: advertise gzip support to transformer through X-Feature-Gzip-Support header (#3990) * chore: release 1.15.2 (#3992) * fix: update error parsing of eloqua (#3996) * fix(eloqua): change null values to empty strings inspite of "null" * address comments * add logic to consider some warning statusCode as success * fix lint issues * fix: corrupted rsources stats captured by processor for dropped jobs (#3999) * chore: release 1.15.3 (#3998) * fix: invalid memory address or nil pointer dereference in googlecloudfunction * fix: merge error blocks in gcf * chore: add test case for body close * chore: add test case for body close --------- Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com> Co-authored-by: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: Aris Tzoumas <atzoumas@rudderstack.com>
This was referenced Oct 30, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were sending null values as "null". For null values, Eloqua doesn't show any warning but as we were sending "null" they were showing an invalid value warning. With this PR we are fixing that. We are also considering warning with statusCode ELQ-00040 as a success when none of the unique fields are invalid.
Linear Ticket
Security