-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: sources async job #4008
Conversation
d463c62
to
43e41fc
Compare
b9ac78f
to
6cc7b72
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4008 +/- ##
==========================================
+ Coverage 71.53% 71.73% +0.19%
==========================================
Files 373 373
Lines 54838 54941 +103
==========================================
+ Hits 39227 39410 +183
+ Misses 13273 13199 -74
+ Partials 2338 2332 -6
☔ View full report in Codecov by Sentry. |
6cc7b72
to
ad0ec2b
Compare
warehouse/source/http.go
Outdated
}) | ||
tableNames = lo.Filter(lo.Uniq(tableNames), func(tableName string, i int) bool { | ||
switch strings.ToLower(tableName) { | ||
case "rudder_discards", "rudder_identity_mappings", "rudder_identity_merge_rules": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have enums for these? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have constants for these:
tableNames = lo.Filter(lo.Uniq(tableNames), func(tableName string, i int) bool {
switch strings.ToLower(tableName) {
case whutils.DiscardsTable, whutils.IdentityMappingsTable, whutils.IdentityMergeRulesTable:
return false
default:
return true
}
})
3478270
to
870d927
Compare
2ab2f33
to
59b73c1
Compare
6f120fd
to
98a2ca2
Compare
Description
Linear Ticket
Security