Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: meaningful name for receivers #4064

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Nov 1, 2023

Description

  • Use a more meaningful name for the receivers present in warehouse/internal/repo package. Currently, we are using repo everywhere. Also we already have a repo struct present inside the package.
  • Some feedback in here

Linear Ticket

  • Resolves PIPE-472

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr changed the title chore: meaningful name for receiver chore: meaningful name for receivers Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 123 lines in your changes are missing coverage. Please review.

Comparison is base (b80d273) 71.53% compared to head (a29fa92) 71.70%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4064      +/-   ##
==========================================
+ Coverage   71.53%   71.70%   +0.17%     
==========================================
  Files         373      373              
  Lines       54826    54941     +115     
==========================================
+ Hits        39219    39397     +178     
+ Misses      13272    13207      -65     
- Partials     2335     2337       +2     
Files Coverage Δ
warehouse/api/http.go 78.94% <100.00%> (ø)
warehouse/app.go 89.59% <100.00%> (ø)
warehouse/integrations/testhelper/setup.go 99.68% <100.00%> (ø)
warehouse/internal/model/upload.go 100.00% <ø> (ø)
warehouse/internal/repo/schema.go 88.88% <100.00%> (ø)
warehouse/internal/repo/staging.go 81.77% <100.00%> (ø)
warehouse/integrations/testhelper/verify.go 89.64% <91.66%> (ø)
warehouse/internal/repo/upload.go 91.01% <98.03%> (ø)
warehouse/internal/model/source.go 91.66% <91.66%> (ø)
warehouse/slave/worker.go 81.74% <76.19%> (-0.88%) ⬇️
... and 4 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr merged commit 9fd3c82 into master Nov 2, 2023
37 checks passed
@fracasula fracasula deleted the chore.repo-receiver-cleanup branch November 2, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants