chore: remove panic and trigger full update on incremental update failure #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sidddddarth
requested review from
atzoum,
cisse21,
lvrach,
BonapartePC,
fracasula,
achettyiitr and
pChondros
achettyiitr
approved these changes
Nov 9, 2023
lvrach
approved these changes
Nov 9, 2023
atzoum
approved these changes
Nov 9, 2023
fracasula
approved these changes
Nov 9, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.16.x #4109 +/- ##
==================================================
+ Coverage 71.62% 71.97% +0.35%
==================================================
Files 373 373
Lines 54843 54943 +100
==================================================
+ Hits 39280 39545 +265
+ Misses 13233 13084 -149
+ Partials 2330 2314 -16
☔ View full report in Codecov by Sentry. |
Merged
1 task
This was referenced Nov 12, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
incremental update failure causes a panic. Removing that panic.
Linear Ticket
Resolves PIPE-515
slack thread for context
Security