chore: remove panic and continue with old config on incremental update failure #4108
Conversation
Sidddddarth
requested review from
atzoum,
cisse21,
lvrach,
BonapartePC,
fracasula,
achettyiitr and
pChondros
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4108 +/- ##
==========================================
+ Coverage 71.92% 71.96% +0.04%
==========================================
Files 373 373
Lines 54933 54942 +9
==========================================
+ Hits 39511 39541 +30
+ Misses 13103 13086 -17
+ Partials 2319 2315 -4
☔ View full report in Codecov by Sentry. |
| workspaceID, req, | ||
| )) | ||
| nc.logger.Errorw( | ||
| "workspace was not updated but was not present in previous config", |
There was a problem hiding this comment.
we can just add an alert on this log right?
| if errors.Is(err, ErrIncrementalUpdateFailed) { | ||
| stats.Default.NewStat("config_backend.ErrIncrementalUpdateFailed", stats.CountType).Increment() | ||
| } |
| // reset state here | ||
| nc.lastUpdatedAt = time.Time{} |
There was a problem hiding this comment.
namespaceConfig#Get can react on the ErrIncrementalUpdateFailed by resetting the lastUpdatedAt and calling getFromAPI again. This way we won't have to wait for the next poll to happen
|
If we want this to be released as a patch release ASAP it needs to target |
My bad |
Description
incremental update failure causes a panic. Removing that panic.
Linear Ticket
Slack thread for context
Security