Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(warehouse): warehouse archiver initialize #2697

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

achettyiitr
Copy link
Member

Description

Warehouse archiver Init() is not being called from anywhere. It needs to be initialized during the start of the application from the runner.

Notion Ticket

https://www.notion.so/rudderstacks/Warehouse-archiver-Init-79b09dfb38ed4123ac6d7ac59f7ed656

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 45.44% // Head: 45.49% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (4f6c5a8) compared to base (af2b5a7).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2697      +/-   ##
==========================================
+ Coverage   45.44%   45.49%   +0.04%     
==========================================
  Files         289      289              
  Lines       47997    48000       +3     
==========================================
+ Hits        21814    21838      +24     
+ Misses      24796    24776      -20     
+ Partials     1387     1386       -1     
Impacted Files Coverage Δ
services/pgnotifier/pgnotifier.go 2.83% <0.00%> (ø)
warehouse/deltalake/deltalake.go 1.65% <0.00%> (ø)
warehouse/identity/identity.go 0.45% <0.00%> (ø)
warehouse/redshift/redshift.go 1.52% <0.00%> (ø)
warehouse/slave.go 1.08% <0.00%> (ø)
warehouse/testhelper/setup.go 0.00% <0.00%> (ø)
warehouse/upload.go 18.45% <0.00%> (ø)
runner/runner.go 75.30% <100.00%> (+0.10%) ⬆️
warehouse/constraint.go 89.23% <100.00%> (ø)
warehouse/utils/utils.go 70.84% <100.00%> (+0.27%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants