Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processor): added ability for geolocation enrichment during pipeline processing #3866

Merged
merged 29 commits into from
Oct 25, 2023

reset the config key to original when dealing with GeoEnrichment

d7c2ab1
Select commit
Loading
Failed to load commit list.
Merged

feat(processor): added ability for geolocation enrichment during pipeline processing #3866

reset the config key to original when dealing with GeoEnrichment
d7c2ab1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 25, 2023 in 0s

71.38% (-0.13%) compared to d0d99bc

View this Pull Request on Codecov

71.38% (-0.13%) compared to d0d99bc

Details

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (d0d99bc) 71.50% compared to head (d7c2ab1) 71.38%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3866      +/-   ##
==========================================
- Coverage   71.50%   71.38%   -0.13%     
==========================================
  Files         369      371       +2     
  Lines       54226    54473     +247     
==========================================
+ Hits        38777    38886     +109     
- Misses      13162    13274     +112     
- Partials     2287     2313      +26     
Files Coverage Δ
backend-config/types.go 88.88% <ø> (ø)
processor/manager.go 92.00% <100.00%> (+1.83%) ⬆️
testhelper/backendconfigtest/source_builder.go 84.61% <100.00%> (+1.28%) ⬆️
app/apphandlers/embeddedAppHandler.go 74.66% <66.66%> (-0.26%) ⬇️
app/apphandlers/setup.go 83.72% <75.00%> (-1.42%) ⬇️
processor/processor.go 88.52% <86.95%> (-0.11%) ⬇️
runner/runner.go 69.54% <50.00%> (+0.12%) ⬆️
app/apphandlers/processorAppHandler.go 7.57% <0.00%> (-0.27%) ⬇️
services/geolocation/maxmind.go 64.28% <64.28%> (ø)
internal/enricher/geolocation.go 79.51% <79.51%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.