-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: minor processor cleanup #3876
Conversation
ad145a4
to
2f0205c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3876 +/- ##
==========================================
+ Coverage 71.53% 71.74% +0.20%
==========================================
Files 373 373
Lines 54826 54891 +65
==========================================
+ Hits 39219 39379 +160
+ Misses 13272 13190 -82
+ Partials 2335 2322 -13
☔ View full report in Codecov by Sentry. |
2f0205c
to
886479b
Compare
@Sidddddarth how do we verify no regression has been introduced? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transformer.EventFilterStage
is unusedtransformer.TrackingPlanValidationStage
is being used byprocessor_test.go
It might be best to unexport stage constants, since they appear to be for internal use only:
userTransformerStage
destTransformerStage
trackingPlanValidationStage
adding some coverage here |
131bf8a
to
816af29
Compare
816af29
to
4b6979c
Compare
7c23ca0
to
fefd591
Compare
Please add a description of the changes, helpful to the review process |
139d017
to
0d2365d
Compare
why is it on a separate PR? |
That started when there were no tests for reporting at all. Considering we have some now, they're of no use anymore. |
2d29d1e
to
0746bbf
Compare
3824cd2
to
ae1e5bd
Compare
8ac08f0
to
99bccdb
Compare
99ac037
to
ab98a23
Compare
Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
d955e04
to
988ff9a
Compare
Description
Cleaned up some processor code.
Specifically the usage of 2 flags(
trackingPlanEnabled
anduserTransformationEnabled
) to decide thePU
andinPU
at various stages during the computation of metrics.Also using stage literals from one package(
utils/types
) instead of two earlier(processor/transformer
andutils/types
).Linear Ticket
< Replace with Linear Link >
Security