Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use transformerdocker image that is publicly available #3916

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

lvrach
Copy link
Member

@lvrach lvrach commented Sep 27, 2023

Description

While testing rudder-server in codespaces I got an error when try to run docker-compose up.

The docker image we are using requires to login to our docker hub.

I've used a public image to make development of rudder-server more acesible.

Notion ticket

https://linear.app/rudderstack/issue/PIPE-367/use-public-transformer-image-in-docker-compose-file

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f13dbc3) 70.39% compared to head (666fb10) 70.37%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3916      +/-   ##
==========================================
- Coverage   70.39%   70.37%   -0.02%     
==========================================
  Files         357      357              
  Lines       53639    53639              
==========================================
- Hits        37758    37750       -8     
- Misses      13615    13622       +7     
- Partials     2266     2267       +1     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@atzoum atzoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the others changed by #3115?

@lvrach lvrach merged commit 5f3820f into master Oct 9, 2023
35 checks passed
@lvrach lvrach deleted the chore/pipe-367-use-public-transformer-image branch October 9, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants