chore: sampling errors if no message in the batch succeeds #3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fracasula
requested review from
lvrach,
atzoum,
cisse21,
ItsSudip,
pChondros,
BonapartePC,
achettyiitr,
Sidddddarth and
sandeepdsvs
achettyiitr
approved these changes
Sep 27, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3918 +/- ##
==========================================
- Coverage 69.21% 69.21% -0.01%
==========================================
Files 357 357
Lines 53132 53140 +8
==========================================
+ Hits 36776 36779 +3
- Misses 14041 14046 +5
Partials 2315 2315
☔ View full report in Codecov by Sentry. |
atzoum
approved these changes
Sep 27, 2023
fracasula
deleted the
feature/pipe-369-cars-unable-to-process-any-of-the-event-in-the-batch
branch
This was referenced Oct 9, 2023
Closed
This was referenced Oct 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small change to allow customers to figure out why no messages are getting through without asking for our help.
This happened to Cars, the wrong Avro schema was being used and they were not able to figure out why.
Linear Ticket
< Linear Link >
Security