feat: oauth access denied handling #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
September 11, 2023 21:48
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
…ant error while refreshing the token
- include relevant status-codes - remove unnecessary printf statements
…ilure & success) - refactor authStatus toggle handling in deleteUsers - correction of test-cases in deleteUsers
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3960 +/- ##
==========================================
+ Coverage 71.07% 71.35% +0.27%
==========================================
Files 368 368
Lines 54083 54130 +47
==========================================
+ Hits 38441 38624 +183
+ Misses 13343 13210 -133
+ Partials 2299 2296 -3
☔ View full report in Codecov by Sentry. |
koladilip
approved these changes
Oct 18, 2023
fracasula
approved these changes
Oct 18, 2023
Yes. After completion of testing I have removed |
Great, thanks 👍 |
fracasula
added a commit
that referenced
this pull request
Oct 19, 2023
* fix: access_denied error handling for OAuth destinations * fix: mock oauth service Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: rename ref_token_invalid_grant constant Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: update the method for authStatus toggle to PUT * chore: include contract changes * fix: add AUTH_STATUS_INACTIVE handling in regulation-worker * chore: refactoring some changes, adding logic for handling invalid_grant error while refreshing the token * fix: address comments - include relevant status-codes - remove unnecessary printf statements * fix: send badrequest when required parameters are not sent in tests * fix: change response error message for authStatusInactive req(both failure & success) - refactor authStatus toggle handling in deleteUsers - correction of test-cases in deleteUsers * fix: add multiple go-routines tests for authStatus/toggle * fix: formatting * fix: rename variables, send right error message post inactivation of authStatus * fix: comment correction * fix: remove unused argument * fix: updated wrong url status-code to 404 * fix: propagate error message rather than error type * fix: unused return variable removal * fix: remove secret info from cache after inactivating authStatus * fix: rename oauth function & update related mock --------- Signed-off-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Francesco Casula <fracasula@users.noreply.github.com>
fracasula
added a commit
that referenced
this pull request
Oct 30, 2023
* fix: access_denied error handling for OAuth destinations * fix: mock oauth service Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: rename ref_token_invalid_grant constant Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: update the method for authStatus toggle to PUT * chore: include contract changes * fix: add AUTH_STATUS_INACTIVE handling in regulation-worker * chore: refactoring some changes, adding logic for handling invalid_grant error while refreshing the token * fix: address comments - include relevant status-codes - remove unnecessary printf statements * fix: send badrequest when required parameters are not sent in tests * fix: change response error message for authStatusInactive req(both failure & success) - refactor authStatus toggle handling in deleteUsers - correction of test-cases in deleteUsers * fix: add multiple go-routines tests for authStatus/toggle * fix: formatting * fix: rename variables, send right error message post inactivation of authStatus * fix: comment correction * fix: remove unused argument * fix: updated wrong url status-code to 404 * fix: propagate error message rather than error type * fix: unused return variable removal * fix: remove secret info from cache after inactivating authStatus * fix: rename oauth function & update related mock --------- Signed-off-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Francesco Casula <fracasula@users.noreply.github.com>
fracasula
added a commit
that referenced
this pull request
Oct 30, 2023
* fix: access_denied error handling for OAuth destinations * fix: mock oauth service Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: rename ref_token_invalid_grant constant Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: update the method for authStatus toggle to PUT * chore: include contract changes * fix: add AUTH_STATUS_INACTIVE handling in regulation-worker * chore: refactoring some changes, adding logic for handling invalid_grant error while refreshing the token * fix: address comments - include relevant status-codes - remove unnecessary printf statements * fix: send badrequest when required parameters are not sent in tests * fix: change response error message for authStatusInactive req(both failure & success) - refactor authStatus toggle handling in deleteUsers - correction of test-cases in deleteUsers * fix: add multiple go-routines tests for authStatus/toggle * fix: formatting * fix: rename variables, send right error message post inactivation of authStatus * fix: comment correction * fix: remove unused argument * fix: updated wrong url status-code to 404 * fix: propagate error message rather than error type * fix: unused return variable removal * fix: remove secret info from cache after inactivating authStatus * fix: rename oauth function & update related mock --------- Signed-off-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Francesco Casula <fracasula@users.noreply.github.com>
This was referenced Oct 30, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves INT-367
Linear Ticket
https://linear.app/rudderstack/issue/INT-367/testing-review-and-release
Security