-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: oauth access denied handling #3960
Conversation
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
…ant error while refreshing the token
- include relevant status-codes - remove unnecessary printf statements
…ilure & success) - refactor authStatus toggle handling in deleteUsers - correction of test-cases in deleteUsers
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3960 +/- ##
==========================================
+ Coverage 71.07% 71.35% +0.27%
==========================================
Files 368 368
Lines 54083 54130 +47
==========================================
+ Hits 38441 38624 +183
+ Misses 13343 13210 -133
+ Partials 2299 2296 -3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanpj2292 LGTM 👍 Has this been tested on dev?
Yes. After completion of testing I have removed |
Great, thanks 👍 |
* fix: access_denied error handling for OAuth destinations * fix: mock oauth service Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: rename ref_token_invalid_grant constant Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: update the method for authStatus toggle to PUT * chore: include contract changes * fix: add AUTH_STATUS_INACTIVE handling in regulation-worker * chore: refactoring some changes, adding logic for handling invalid_grant error while refreshing the token * fix: address comments - include relevant status-codes - remove unnecessary printf statements * fix: send badrequest when required parameters are not sent in tests * fix: change response error message for authStatusInactive req(both failure & success) - refactor authStatus toggle handling in deleteUsers - correction of test-cases in deleteUsers * fix: add multiple go-routines tests for authStatus/toggle * fix: formatting * fix: rename variables, send right error message post inactivation of authStatus * fix: comment correction * fix: remove unused argument * fix: updated wrong url status-code to 404 * fix: propagate error message rather than error type * fix: unused return variable removal * fix: remove secret info from cache after inactivating authStatus * fix: rename oauth function & update related mock --------- Signed-off-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Francesco Casula <fracasula@users.noreply.github.com>
* fix: access_denied error handling for OAuth destinations * fix: mock oauth service Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: rename ref_token_invalid_grant constant Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: update the method for authStatus toggle to PUT * chore: include contract changes * fix: add AUTH_STATUS_INACTIVE handling in regulation-worker * chore: refactoring some changes, adding logic for handling invalid_grant error while refreshing the token * fix: address comments - include relevant status-codes - remove unnecessary printf statements * fix: send badrequest when required parameters are not sent in tests * fix: change response error message for authStatusInactive req(both failure & success) - refactor authStatus toggle handling in deleteUsers - correction of test-cases in deleteUsers * fix: add multiple go-routines tests for authStatus/toggle * fix: formatting * fix: rename variables, send right error message post inactivation of authStatus * fix: comment correction * fix: remove unused argument * fix: updated wrong url status-code to 404 * fix: propagate error message rather than error type * fix: unused return variable removal * fix: remove secret info from cache after inactivating authStatus * fix: rename oauth function & update related mock --------- Signed-off-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Francesco Casula <fracasula@users.noreply.github.com>
* fix: access_denied error handling for OAuth destinations * fix: mock oauth service Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: rename ref_token_invalid_grant constant Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: update the method for authStatus toggle to PUT * chore: include contract changes * fix: add AUTH_STATUS_INACTIVE handling in regulation-worker * chore: refactoring some changes, adding logic for handling invalid_grant error while refreshing the token * fix: address comments - include relevant status-codes - remove unnecessary printf statements * fix: send badrequest when required parameters are not sent in tests * fix: change response error message for authStatusInactive req(both failure & success) - refactor authStatus toggle handling in deleteUsers - correction of test-cases in deleteUsers * fix: add multiple go-routines tests for authStatus/toggle * fix: formatting * fix: rename variables, send right error message post inactivation of authStatus * fix: comment correction * fix: remove unused argument * fix: updated wrong url status-code to 404 * fix: propagate error message rather than error type * fix: unused return variable removal * fix: remove secret info from cache after inactivating authStatus * fix: rename oauth function & update related mock --------- Signed-off-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Francesco Casula <fracasula@users.noreply.github.com>
Description
Resolves INT-367
Linear Ticket
https://linear.app/rudderstack/issue/INT-367/testing-review-and-release
Security