Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: flaky validations test #4027

Merged
merged 1 commit into from
Oct 27, 2023
Merged

chore: flaky validations test #4027

merged 1 commit into from
Oct 27, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Oct 27, 2023

Description

  • Even now, a few times tests are failing with i/o timeout, since we are running all of the tests in parallel. Removing parallel for now so that it can be more stable.
https://github.com/rudderlabs/rudder-server/actions/runs/6666283593/job/18117517599?pr=4026
=== FAIL: warehouse/validations TestValidator/Fetch_schema (25.01s)
    validate_test.go:368: 
        	Error Trace:	/home/runner/work/rudder-server/rudder-server/warehouse/validations/validate_test.go:368
        	Error:      	Received unexpected error:
        	            	fetch schema: fetching schema: read tcp [::1]:33190->[::1]:32872: i/o timeout
        	Test:       	TestValidator/Fetch_schema
    --- FAIL: TestValidator/Fetch_schema (25.01s)
  • Although, if we feel that test times become a burden, we can explore other options in the future. Alteast we will stable tetsts.
package=./warehouse/validations/... make test
go install github.com/golang/mock/mockgen@v1.6.0
go install mvdan.cc/gofumpt@latest
go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.28.1
go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.2.0
go install gotest.tools/gotestsum@v1.10.0
go install golang.org/x/tools/cmd/goimports@latest
SLOW=0 gotestsum --format pkgname-and-test-fails -- -p=1 -v -failfast -shuffle=on -coverprofile=profile.out -covermode=atomic -coverpkg=./... -vet=all --timeout=15m ./warehouse/validations/... && touch _testok || true
✓  warehouse/validations (11.453s) (coverage: 9.7% of statements in ./...)

Linear Ticket

  • Resolves PIPE-453

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr changed the title chore: fix validations test chore: flaky validations test Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa8044a) 71.36% compared to head (3533837) 71.38%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4027      +/-   ##
==========================================
+ Coverage   71.36%   71.38%   +0.01%     
==========================================
  Files         371      371              
  Lines       54681    54681              
==========================================
+ Hits        39023    39033      +10     
+ Misses      13323    13316       -7     
+ Partials     2335     2332       -3     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr merged commit 3ee4c7b into master Oct 27, 2023
50 checks passed
@fracasula fracasula deleted the chore.validations-tests branch October 27, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants